2021-03-26 07:58:38

by Richard Zhu

[permalink] [raw]
Subject: RE: Re: [PATCH v3 3/3] PCI: imx: clear vreg bypass when pcie vph voltage is 3v3

> -----Original Message-----
> From: Krzysztof WilczyƄski <[email protected]>
> Sent: Friday, March 26, 2021 3:46 PM
> To: Richard Zhu <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; dl-linux-imx
> <[email protected]>; [email protected];
> [email protected]; [email protected]
> Subject: Re: [PATCH v3 3/3] PCI: imx: clear vreg bypass when pcie vph
> voltage is 3v3
> Hi,
>
> > + /*
> > + * Regarding to the datasheet, the PCIE_VPH is suggested
> > + * to be 1.8V. If the PCIE_VPH is supplied by 3.3V, the
> > + * VREG_BYPASS should be cleared to zero.
> > + */
> [...]
>
> A small nitpick here. What about the following:
>
> Regarding the data sheet, the PCIE_VPH is suggested to be 1.8V.
> If the PCIE_VPH is supplied with 3.3V, the VREG_BYPASS should be
> cleared to zero.
>
> What do you think?
[Richard Zhu] Hi Krzysztof:
Thanks for your comments. You're right.
It should be "Regarding something", not the "Regarding to something"
Thanks. ????

Best Regards
Richard Zhu

>
> Krzysztof