On Wed, Dec 16, 2020 at 09:19:44PM +0800, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
Looks like a good fix, but read this about the changelog title:
https://lore.kernel.org/r/[email protected]
> Signed-off-by: Zheng Yongjun <[email protected]>
> ---
> drivers/pci/controller/dwc/pci-layerscape-ep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> index 84206f265e54..917ba8d254fc 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> @@ -178,7 +178,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
> pci->dev = dev;
> pci->ops = pcie->drvdata->dw_pcie_ops;
>
> - ls_epc->bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4),
> + ls_epc->bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4);
>
> pcie->pci = pci;
> pcie->ls_epc = ls_epc;
> --
> 2.22.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Wed, Jan 06, 2021 at 01:07:22PM -0600, Bjorn Helgaas wrote:
> On Wed, Dec 16, 2020 at 09:19:44PM +0800, Zheng Yongjun wrote:
> > Replace a comma between expression statements by a semicolon.
>
> Looks like a good fix, but read this about the changelog title:
>
> https://lore.kernel.org/r/[email protected]
I would request NXP maintainers to take this patch, rewrite it as
Bjorn requested and resend it as fast as possible, this is a very
relevant fix.
Thanks,
Lorenzo
> > Signed-off-by: Zheng Yongjun <[email protected]>
> > ---
> > drivers/pci/controller/dwc/pci-layerscape-ep.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > index 84206f265e54..917ba8d254fc 100644
> > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > @@ -178,7 +178,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
> > pci->dev = dev;
> > pci->ops = pcie->drvdata->dw_pcie_ops;
> >
> > - ls_epc->bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4),
> > + ls_epc->bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4);
> >
> > pcie->pci = pci;
> > pcie->ls_epc = ls_epc;
> > --
> > 2.22.0
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > [email protected]
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi,
[...]
> I would request NXP maintainers to take this patch, rewrite it as
> Bjorn requested and resend it as fast as possible, this is a very
> relevant fix.
[...]
Looking at the state of the pci-layerscape-ep.c file in Linus' tree,
this still hasn't been fixed, and it has been a while.
NXP folks, are you intend to pick this up? Do let us know.
Krzysztof
On Sun, Mar 07, 2021 at 07:36:57PM +0100, Krzysztof Wilczyński wrote:
> Hi,
>
> [...]
> > I would request NXP maintainers to take this patch, rewrite it as
> > Bjorn requested and resend it as fast as possible, this is a very
> > relevant fix.
> [...]
>
> Looking at the state of the pci-layerscape-ep.c file in Linus' tree,
> this still hasn't been fixed, and it has been a while.
>
> NXP folks, are you intend to pick this up? Do let us know.
Minghuan, Mingkai, Roy,
either one of you reply and follow up this patch or I will have to
update the MAINTAINERS entry and take action accordingly, you are
not maintaining this driver and I won't maintain your code, sorry.
Lorenzo
> Krzysztof
Yes. It is maintained.
I will send out a patch.
Thanks.
Roy
-----Original Message-----
From: Lorenzo Pieralisi <[email protected]>
On Sun, Mar 07, 2021 at 07:36:57PM +0100, Krzysztof Wilczyński wrote:
> Hi,
>
> [...]
> > I would request NXP maintainers to take this patch, rewrite it as
> > Bjorn requested and resend it as fast as possible, this is a very
> > relevant fix.
> [...]
>
> Looking at the state of the pci-layerscape-ep.c file in Linus' tree,
> this still hasn't been fixed, and it has been a while.
>
> NXP folks, are you intend to pick this up? Do let us know.
Minghuan, Mingkai, Roy,
either one of you reply and follow up this patch or I will have to update the MAINTAINERS entry and take action accordingly, you are not maintaining this driver and I won't maintain your code, sorry.
Lorenzo
> Krzysztof
On Mon, Mar 22, 2021 at 01:40:16PM +0000, Roy Zang wrote:
> Yes. It is maintained.
To be maintained you should review its code please.
> I will send out a patch.
Krzysztof already posted one for you, you just need to ack it:
https://patchwork.kernel.org/project/linux-pci/patch/[email protected]
For the future email exchanges: don't top-post please.
Thanks,
Lorenzo
> Thanks.
> Roy
>
> -----Original Message-----
> From: Lorenzo Pieralisi <[email protected]>
>
> On Sun, Mar 07, 2021 at 07:36:57PM +0100, Krzysztof Wilczyński wrote:
> > Hi,
> >
> > [...]
> > > I would request NXP maintainers to take this patch, rewrite it as
> > > Bjorn requested and resend it as fast as possible, this is a very
> > > relevant fix.
> > [...]
> >
> > Looking at the state of the pci-layerscape-ep.c file in Linus' tree,
> > this still hasn't been fixed, and it has been a while.
> >
> > NXP folks, are you intend to pick this up? Do let us know.
>
> Minghuan, Mingkai, Roy,
>
> either one of you reply and follow up this patch or I will have to update the MAINTAINERS entry and take action accordingly, you are not maintaining this driver and I won't maintain your code, sorry.
>
> Lorenzo
>
> > Krzysztof
> From: Lorenzo Pieralisi <[email protected]>
> On Mon, Mar 22, 2021 at 01:40:16PM +0000, Roy Zang wrote:
> > Yes. It is maintained.
>
> To be maintained you should review its code please.
Sure.
>
> > I will send out a patch.
>
> Krzysztof already posted one for you, you just need to ack it:
>
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchw
> ork.kernel.org%2Fproject%2Flinux-
> pci%2Fpatch%2F20210311033745.1547044-1-
> kw%40linux.com&data=04%7C01%7Croy.zang%40nxp.com%7Ced683ff5
> 093443cb9c1608d8ed41150e%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0
> %7C1%7C637520211070640953%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiM
> C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000
> &sdata=IWTcj7Xs0AdVVIf%2BSFzge6is9D8o0h6SSi7MpibIYcY%3D&r
> eserved=0
>
> For the future email exchanges: don't top-post please.
Acked.
Roy