2023-07-17 06:06:59

by Gaurav Jain

[permalink] [raw]
Subject: RE: [PATCH 1/2] crypto: caam - Change structure type representing DECO MID

Reviewed-by: Gaurav Jain <[email protected]>

> -----Original Message-----
> From: Meenakshi Aggarwal <[email protected]>
> Sent: Wednesday, July 12, 2023 11:37 AM
> To: Horia Geanta <[email protected]>; Varun Sethi <[email protected]>;
> Pankaj Gupta <[email protected]>; Gaurav Jain <[email protected]>;
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]
> Cc: Franck Lenormand <[email protected]>; Meenakshi Aggarwal
> <[email protected]>
> Subject: [PATCH 1/2] crypto: caam - Change structure type representing DECO
> MID
>
> From: Franck LENORMAND <[email protected]>
>
> The structure partid is not suitable to represent the DECO MID register.
>
> This patch replace partid by masterid which is more appropriate.
>
> Signed-off-by: Franck LENORMAND <[email protected]>
> Signed-off-by: Horia Geantă <[email protected]>
> Signed-off-by: Meenakshi Aggarwal <[email protected]>
> ---
> drivers/crypto/caam/regs.h | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/crypto/caam/regs.h b/drivers/crypto/caam/regs.h index
> 189e74c21f0c..0f87bd365582 100644
> --- a/drivers/crypto/caam/regs.h
> +++ b/drivers/crypto/caam/regs.h
> @@ -459,12 +459,6 @@ struct masterid {
> u32 liodn_ls; /* LIODN for non-sequence and seq access */
> };
>
> -/* Partition ID for DMA configuration */ -struct partid {
> - u32 rsvd1;
> - u32 pidr; /* partition ID, DECO */
> -};
> -
> /* RNGB test mode (replicated twice in some configurations) */
> /* Padded out to 0x100 */
> struct rngtst {
> @@ -590,7 +584,7 @@ struct caam_ctrl {
> u32 deco_rsr; /* DECORSR - Deco Request Source */
> u32 rsvd11;
> u32 deco_rq; /* DECORR - DECO Request */
> - struct partid deco_mid[5]; /* DECOxLIODNR - 1 per DECO */
> + struct masterid deco_mid[5]; /* DECOxLIODNR - 1 per DECO */
> u32 rsvd5[22];
>
> /* DECO Availability/Reset Section 120-3ff */
> --
> 2.25.1