Two pmuio domains on ringneck are not defined:
1- PMUIO1: supplied by vcc_3v3 regulator(PMIC RK809)
2- PMUIO2: supplied by vcc_3v3 regulator(PMIC RK809)
The reason why no functional effect was observed is because of that
the above mentionned PMUIO domains were supplied by a regulator
which is always on.
So let's add their definition in the dtsi.
Signed-off-by: Iskander Amara <[email protected]>
---
v2:
- Fix indentation
arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
index 12397755830b..bb1aea82e666 100644
--- a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
+++ b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
@@ -347,6 +347,12 @@ pmic_int: pmic-int {
};
};
+&pmu_io_domains {
+ pmuio1-supply = <&vcc_3v3>;
+ pmuio2-supply = <&vcc_3v3>;
+ status = "okay";
+};
+
&saradc {
vref-supply = <&vcc_1v8>;
status = "okay";
--
2.34.1
Hi Iskander,
Am Montag, 22. Januar 2024, 13:17:50 CET schrieb Iskander Amara:
> Dear Ladies and Gentlemen,
> Is there any feedback about the patch below that you would like to share?
no feedback, change looks good.
I was mainly waiting for the merge-window to close, so that
I can get a nice 6.8-rc1 as base :-)
Heiko
> ________________________________
> From: Iskander Amara <[email protected]>
> Sent: Wednesday, January 3, 2024 5:47 PM
> To: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
> Cc: Quentin Schulz <[email protected]>; Iskander Amara <[email protected]>
> Subject: [PATCH v2] arm64: dts: rockchip: add missing definition of pmu io domains 1 and 2 on ringneck
>
> Two pmuio domains on ringneck are not defined:
> 1- PMUIO1: supplied by vcc_3v3 regulator(PMIC RK809)
> 2- PMUIO2: supplied by vcc_3v3 regulator(PMIC RK809)
>
> The reason why no functional effect was observed is because of that
> the above mentionned PMUIO domains were supplied by a regulator
> which is always on.
>
> So let's add their definition in the dtsi.
>
> Signed-off-by: Iskander Amara <[email protected]>
> ---
> v2:
> - Fix indentation
> arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
> index 12397755830b..bb1aea82e666 100644
> --- a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
> @@ -347,6 +347,12 @@ pmic_int: pmic-int {
> };
> };
>
> +&pmu_io_domains {
> + pmuio1-supply = <&vcc_3v3>;
> + pmuio2-supply = <&vcc_3v3>;
> + status = "okay";
> +};
> +
> &saradc {
> vref-supply = <&vcc_1v8>;
> status = "okay";
> --
> 2.34.1
>
>
On Wed, 3 Jan 2024 17:47:34 +0100, Iskander Amara wrote:
> Two pmuio domains on ringneck are not defined:
> 1- PMUIO1: supplied by vcc_3v3 regulator(PMIC RK809)
> 2- PMUIO2: supplied by vcc_3v3 regulator(PMIC RK809)
>
> The reason why no functional effect was observed is because of that
> the above mentionned PMUIO domains were supplied by a regulator
> which is always on.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: add missing definition of pmu io domains 1 and 2 on ringneck
commit: 16a9c74012c4e4bff6d493832cd648b486046ce1
Best regards,
--
Heiko Stuebner <[email protected]>
Great,
Thank you!
________________________________________
From: Heiko Stuebner <[email protected]>
Sent: Thursday, January 25, 2024 10:12 PM
To: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Iskander Amara; [email protected]; [email protected]
Cc: Heiko Stuebner; Quentin Schulz
Subject: Re: [PATCH v2] arm64: dts: rockchip: add missing definition of pmu io domains 1 and 2 on ringneck
On Wed, 3 Jan 2024 17:47:34 +0100, Iskander Amara wrote:
> Two pmuio domains on ringneck are not defined:
> 1- PMUIO1: supplied by vcc_3v3 regulator(PMIC RK809)
> 2- PMUIO2: supplied by vcc_3v3 regulator(PMIC RK809)
>
> The reason why no functional effect was observed is because of that
> the above mentionned PMUIO domains were supplied by a regulator
> which is always on.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: add missing definition of pmu io domains 1 and 2 on ringneck
commit: 16a9c74012c4e4bff6d493832cd648b486046ce1
Best regards,
--
Heiko Stuebner <[email protected]>