2019-04-01 08:39:39

by Steve Twiss

Subject: RE: [RFC] ARM: dts: imx: Fix the AR803X phy-mode

Hi Fabio,

On 30 March 2019 15:51 Fabio Estevam, wrote:

> Subject: [RFC] ARM: dts: imx: Fix the AR803X phy-mode
>
> Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")
> exposed an issue on imx DTS files using AR8031/AR8035 PHYs.
>
> The end result is that the boards can no longer obtain an IP address
> via UDHCP, for example.

[...]

> arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 +-

[...]

> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index a0705066ccba..185fb17a3500 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -202,7 +202,7 @@
> &fec {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_enet>;
> - phy-mode = "rgmii";
> + phy-mode = "rgmii-id";
> phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
> status = "okay";
> };

[...]

This patch looks surprisingly similar to this one ;)
https://lore.kernel.org/patchwork/patch/1052588/

Link: https://lkml.kernel.org/r/1397569821-5530-4-git-send-email-thomas.petazzoni@free-electrons.com
Tested-by: Steve Twiss <[email protected]>
Tested-by: Adam Thomson <[email protected]>
Signed-off-by: Steve Twiss <[email protected]>

Regards,
Steve

2019-04-01 12:50:15

by Fabio Estevam

Subject: Re: [RFC] ARM: dts: imx: Fix the AR803X phy-mode

Hi Steve,

On Mon, Apr 1, 2019 at 5:38 AM Steve Twiss
<[email protected]> wrote:

> This patch looks surprisingly similar to this one ;)
> https://lore.kernel.org/patchwork/patch/1052588/
>
> Link: https://lkml.kernel.org/r/1397569821-5530-4-git-send-email-thomas.petazzoni@free-electrons.com
> Tested-by: Steve Twiss <[email protected]>
> Tested-by: Adam Thomson <[email protected]>
> Signed-off-by: Steve Twiss <[email protected]>

I put your attributions in the formal patch that I have just submitted.

Thanks