2020-12-31 22:11:22

by J. Neuschäfer

[permalink] [raw]
Subject: checkpatch.pl: Bogus case of DT_SPLIT_BINDING_PATCH

Hi,

I've encountered a case where the DT_SPLIT_BINDING_PATCH warning was
emitted even though I didn't change anything outside of Documentation/
devicetree/bindings. I just converted a binding from plain text to YAML.

Here's a transcript of checkpatch (from Linux 5.11-rc1)'s output:

$ scripts/checkpatch.pl --strict patches-wpcm/0001-dt-bindings-arm-Convert-nuvoton-npcm750-binding-to-Y.patch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31:
deleted file mode 100644

WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst

WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst

total: 0 errors, 3 warnings, 0 checks, 21 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

patches-wpcm/0001-dt-bindings-arm-Convert-nuvoton-npcm750-binding-to-Y.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


I attached the patch, for reference.


Best regards,
Jonathan Neuschäfer


Attachments:
(No filename) (0.00 B)
signature.asc (849.00 B)
Download all attachments

2021-01-01 01:58:18

by Joe Perches

[permalink] [raw]
Subject: Re: checkpatch.pl: Bogus case of DT_SPLIT_BINDING_PATCH

On Thu, 2020-12-31 at 23:04 +0100, Jonathan Neusch?fer wrote:
> Hi,
>
> I've encountered a case where the DT_SPLIT_BINDING_PATCH warning was
> emitted even though I didn't change anything outside of Documentation/
> devicetree/bindings. I just converted a binding from plain text to YAML.

Rob? Your code...

> Here's a transcript of checkpatch (from Linux 5.11-rc1)'s output:
>
> ??$ scripts/checkpatch.pl --strict patches-wpcm/0001-dt-bindings-arm-Convert-nuvoton-npcm750-binding-to-Y.patch
> ??WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> ??#31:
> ??deleted file mode 100644
> ??
>
> ??WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
> ??
>
> ??WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
> ??
>
> ??total: 0 errors, 3 warnings, 0 checks, 21 lines checked
> ??
>
> ??NOTE: For some of the reported defects, checkpatch may be able to
> ????????mechanically convert to the typical style using --fix or --fix-inplace.
> ??
>
> ??patches-wpcm/0001-dt-bindings-arm-Convert-nuvoton-npcm750-binding-to-Y.patch has style problems, please review.
> ??
>
> ??NOTE: If any of the errors are false positives, please report
> ????????them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
>
> I attached the patch, for reference.
>
>
> Best regards,
> Jonathan Neusch?fer