2020-11-19 08:25:25

by David Gow

Subject: [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL

Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
functions, it should depend on HAS_IOMEM.

This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
HAS_IOMEM.

Signed-off-by: David Gow <[email protected]>
---
drivers/fpga/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index 7cd5a29fc437..5645226ca3ce 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -142,6 +142,7 @@ config FPGA_DFL
tristate "FPGA Device Feature List (DFL) support"
select FPGA_BRIDGE
select FPGA_REGION
+ depends on HAS_IOMEM
help
Device Feature List (DFL) defines a feature list structure that
creates a linked list of feature headers within the MMIO space
--
2.29.2.454.gaff20da3a2-goog

2020-11-19 11:20:28

by Xu Yilun

Subject: Re: [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL

Thanks for the fix, looks good to me.

Thanks,
Yilun

On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote:
> Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
> 'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
> functions, it should depend on HAS_IOMEM.
>
> This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
> HAS_IOMEM.
>
> Signed-off-by: David Gow <[email protected]>
> ---
> drivers/fpga/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index 7cd5a29fc437..5645226ca3ce 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -142,6 +142,7 @@ config FPGA_DFL
> tristate "FPGA Device Feature List (DFL) support"
> select FPGA_BRIDGE
> select FPGA_REGION
> + depends on HAS_IOMEM
> help
> Device Feature List (DFL) defines a feature list structure that
> creates a linked list of feature headers within the MMIO space
> --
> 2.29.2.454.gaff20da3a2-goog

2020-11-20 06:29:25

by Moritz Fischer

Subject: Re: [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL

Hi David,

On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote:
> Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
> 'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
> functions, it should depend on HAS_IOMEM.
>
> This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
> HAS_IOMEM.
>
> Signed-off-by: David Gow <[email protected]>
> ---
> drivers/fpga/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index 7cd5a29fc437..5645226ca3ce 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -142,6 +142,7 @@ config FPGA_DFL
> tristate "FPGA Device Feature List (DFL) support"
> select FPGA_BRIDGE
> select FPGA_REGION
> + depends on HAS_IOMEM
> help
> Device Feature List (DFL) defines a feature list structure that
> creates a linked list of feature headers within the MMIO space
> --
> 2.29.2.454.gaff20da3a2-goog
>
Do you think we can add a Fixes: tag for this?

Thanks,
Moritz

2020-11-20 07:34:48

by David Gow

Subject: Re: [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL

On Fri, Nov 20, 2020 at 2:27 PM Moritz Fischer <[email protected]> wrote:
>
> Hi David,
>
> On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote:
> > Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
> > 'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
> > functions, it should depend on HAS_IOMEM.
> >
> > This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
> > HAS_IOMEM.
> >
> > Signed-off-by: David Gow <[email protected]>
> > ---
> > drivers/fpga/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> > index 7cd5a29fc437..5645226ca3ce 100644
> > --- a/drivers/fpga/Kconfig
> > +++ b/drivers/fpga/Kconfig
> > @@ -142,6 +142,7 @@ config FPGA_DFL
> > tristate "FPGA Device Feature List (DFL) support"
> > select FPGA_BRIDGE
> > select FPGA_REGION
> > + depends on HAS_IOMEM
> > help
> > Device Feature List (DFL) defines a feature list structure that
> > creates a linked list of feature headers within the MMIO space
> > --
> > 2.29.2.454.gaff20da3a2-goog
> >
> Do you think we can add a Fixes: tag for this?

Sure. I think it should be:

Fixes: 543be3d ("fpga: add device feature list support")

Let me know if you want me to re-send the patch with that included.

Cheers,
-- David

2020-11-20 07:48:35

by Xu Yilun

Subject: Re: [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL

On Fri, Nov 20, 2020 at 03:30:35PM +0800, David Gow wrote:
> On Fri, Nov 20, 2020 at 2:27 PM Moritz Fischer <[email protected]> wrote:
> >
> > Hi David,
> >
> > On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote:
> > > Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
> > > 'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
> > > functions, it should depend on HAS_IOMEM.
> > >
> > > This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
> > > HAS_IOMEM.
> > >
> > > Signed-off-by: David Gow <[email protected]>
> > > ---
> > > drivers/fpga/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> > > index 7cd5a29fc437..5645226ca3ce 100644
> > > --- a/drivers/fpga/Kconfig
> > > +++ b/drivers/fpga/Kconfig
> > > @@ -142,6 +142,7 @@ config FPGA_DFL
> > > tristate "FPGA Device Feature List (DFL) support"
> > > select FPGA_BRIDGE
> > > select FPGA_REGION
> > > + depends on HAS_IOMEM
> > > help
> > > Device Feature List (DFL) defines a feature list structure that
> > > creates a linked list of feature headers within the MMIO space
> > > --
> > > 2.29.2.454.gaff20da3a2-goog
> > >
> > Do you think we can add a Fixes: tag for this?
>
> Sure. I think it should be:
>
> Fixes: 543be3d ("fpga: add device feature list support")

I think it should be:

Fixes: 89eb35e810a8 ("fpga: dfl: map feature mmio resources in their own feature drivers")

Thanks,
Yilun

>
> Let me know if you want me to re-send the patch with that included.
>
> Cheers,
> -- David

2020-11-20 21:52:36

by Moritz Fischer

Subject: Re: [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL

Hi David,

On Fri, Nov 20, 2020 at 03:40:13PM +0800, Xu Yilun wrote:
> On Fri, Nov 20, 2020 at 03:30:35PM +0800, David Gow wrote:
> > On Fri, Nov 20, 2020 at 2:27 PM Moritz Fischer <[email protected]> wrote:
> > >
> > > Hi David,
> > >
> > > On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote:
> > > > Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
> > > > 'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
> > > > functions, it should depend on HAS_IOMEM.
> > > >
> > > > This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
> > > > HAS_IOMEM.
> > > >
> > > > Signed-off-by: David Gow <[email protected]>
> > > > ---
> > > > drivers/fpga/Kconfig | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> > > > index 7cd5a29fc437..5645226ca3ce 100644
> > > > --- a/drivers/fpga/Kconfig
> > > > +++ b/drivers/fpga/Kconfig
> > > > @@ -142,6 +142,7 @@ config FPGA_DFL
> > > > tristate "FPGA Device Feature List (DFL) support"
> > > > select FPGA_BRIDGE
> > > > select FPGA_REGION
> > > > + depends on HAS_IOMEM
> > > > help
> > > > Device Feature List (DFL) defines a feature list structure that
> > > > creates a linked list of feature headers within the MMIO space
> > > > --
> > > > 2.29.2.454.gaff20da3a2-goog
> > > >
> > > Do you think we can add a Fixes: tag for this?
> >
> > Sure. I think it should be:
> >
> > Fixes: 543be3d ("fpga: add device feature list support")
>
> I think it should be:
>
> Fixes: 89eb35e810a8 ("fpga: dfl: map feature mmio resources in their own feature drivers")
I think so, yes.

Can you resend?

Cheers