Commit 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU")
added the GV11B GPU device-tree bindings information but incorrectly
added an additional 0 to the size of the addresses in the example.
Fixes: 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU")
Signed-off-by: Jon Hunter <[email protected]>
---
Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt
index 662a3c8a7d29..cc6ce5221a38 100644
--- a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt
+++ b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt
@@ -97,8 +97,8 @@ Example for GV11B:
gpu@17000000 {
compatible = "nvidia,gv11b";
- reg = <0x17000000 0x10000000>,
- <0x18000000 0x10000000>;
+ reg = <0x17000000 0x1000000>,
+ <0x18000000 0x1000000>;
interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "stall", "nonstall";
--
2.25.1
On Tue, Nov 24, 2020 at 12:18:42PM +0000, Jon Hunter wrote:
> Commit 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU")
> added the GV11B GPU device-tree bindings information but incorrectly
> added an additional 0 to the size of the addresses in the example.
>
> Fixes: 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU")
> Signed-off-by: Jon Hunter <[email protected]>
> ---
> Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Thierry Reding <[email protected]>
On Tue, 24 Nov 2020 12:18:42 +0000, Jon Hunter wrote:
> Commit 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU")
> added the GV11B GPU device-tree bindings information but incorrectly
> added an additional 0 to the size of the addresses in the example.
>
> Fixes: 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU")
> Signed-off-by: Jon Hunter <[email protected]>
> ---
> Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Applied, thanks!
But really, it's just an example and rather than fix trivial things in
txt bindings, convert them to schema please.
On Mon, Dec 07, 2020 at 05:13:52PM -0600, Rob Herring wrote:
> On Tue, 24 Nov 2020 12:18:42 +0000, Jon Hunter wrote:
> > Commit 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU")
> > added the GV11B GPU device-tree bindings information but incorrectly
> > added an additional 0 to the size of the addresses in the example.
> >
> > Fixes: 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU")
> > Signed-off-by: Jon Hunter <[email protected]>
> > ---
> > Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
>
> Applied, thanks!
>
> But really, it's just an example and rather than fix trivial things in
> txt bindings, convert them to schema please.
The conversion to schema of this binding was part of a series I sent out
earlier this year converting a bunch of Tegra-related bindings. At the
time you had requested that rather than converting one binding after
another it might be easier to review if whole directories were converted
at a time.
I've been struggling to find time to do so, so I wonder if you'd prefer
me to send out that series again, or perhaps in smaller chunks? That
sounds better than not doing any conversions at all because I lack the
time to do whole directories at once.
Thierry
On Tue, Dec 8, 2020 at 7:52 AM Thierry Reding <[email protected]> wrote:
>
> On Mon, Dec 07, 2020 at 05:13:52PM -0600, Rob Herring wrote:
> > On Tue, 24 Nov 2020 12:18:42 +0000, Jon Hunter wrote:
> > > Commit 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU")
> > > added the GV11B GPU device-tree bindings information but incorrectly
> > > added an additional 0 to the size of the addresses in the example.
> > >
> > > Fixes: 90a09178f309 ("dt-bindings: Add documentation for GV11B GPU")
> > > Signed-off-by: Jon Hunter <[email protected]>
> > > ---
> > > Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> >
> > Applied, thanks!
> >
> > But really, it's just an example and rather than fix trivial things in
> > txt bindings, convert them to schema please.
>
> The conversion to schema of this binding was part of a series I sent out
> earlier this year converting a bunch of Tegra-related bindings. At the
> time you had requested that rather than converting one binding after
> another it might be easier to review if whole directories were converted
> at a time.
That's largely just because the issues tend to be the same (both doing
the conversion and reviewing it).
> I've been struggling to find time to do so, so I wonder if you'd prefer
> me to send out that series again, or perhaps in smaller chunks? That
> sounds better than not doing any conversions at all because I lack the
> time to do whole directories at once.
The whole series is fine.
Rob