Commit 849f3127bb46 ("switch /dev/kmsg to ->write_iter()") refactored
devkmsg_write() and left over a dead assignment on the variable 'len'.
Hence, make clang-analyzer warns:
kernel/printk/printk.c:744:4: warning: Value stored to 'len' is never read
[clang-analyzer-deadcode.DeadStores]
len -= endp - line;
^
Simply remove this obsolete dead assignment here.
Signed-off-by: Lukas Bulwahn <[email protected]>
---
applies cleanly on current master and next-20201130
Petr, please pick this minor non-urgent clean-up patch.
kernel/printk/printk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index f279d4fbd9dd..6e4e38b7cd91 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -741,7 +741,6 @@ static ssize_t devkmsg_write(struct kiocb *iocb, struct iov_iter *from)
if (LOG_FACILITY(u) != 0)
facility = LOG_FACILITY(u);
endp++;
- len -= endp - line;
line = endp;
}
}
--
2.17.1
On Mon 2020-11-30 13:49:15, Lukas Bulwahn wrote:
> Commit 849f3127bb46 ("switch /dev/kmsg to ->write_iter()") refactored
> devkmsg_write() and left over a dead assignment on the variable 'len'.
>
> Hence, make clang-analyzer warns:
>
> kernel/printk/printk.c:744:4: warning: Value stored to 'len' is never read
> [clang-analyzer-deadcode.DeadStores]
> len -= endp - line;
> ^
>
> Simply remove this obsolete dead assignment here.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> applies cleanly on current master and next-20201130
>
> Petr, please pick this minor non-urgent clean-up patch.
>
> kernel/printk/printk.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index f279d4fbd9dd..6e4e38b7cd91 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -741,7 +741,6 @@ static ssize_t devkmsg_write(struct kiocb *iocb, struct iov_iter *from)
> if (LOG_FACILITY(u) != 0)
> facility = LOG_FACILITY(u);
> endp++;
> - len -= endp - line;
> line = endp;
> }
> }
Yup, it was used to write the trailing '\0'. But it is done earlier
now. So, it is not longer needed.
Reviewed-by: Petr Mladek <[email protected]>
Best Regards,
Petr
PS: I'll give it few days just in case anyone else would want to
review it. I'll push it then unless anyone complains.
On (20/11/30 16:37), Petr Mladek wrote:
> On Mon 2020-11-30 13:49:15, Lukas Bulwahn wrote:
[..]
> > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> > index f279d4fbd9dd..6e4e38b7cd91 100644
> > --- a/kernel/printk/printk.c
> > +++ b/kernel/printk/printk.c
> > @@ -741,7 +741,6 @@ static ssize_t devkmsg_write(struct kiocb *iocb, struct iov_iter *from)
> > if (LOG_FACILITY(u) != 0)
> > facility = LOG_FACILITY(u);
> > endp++;
> > - len -= endp - line;
> > line = endp;
> > }
> > }
>
> Yup, it was used to write the trailing '\0'. But it is done earlier
> now. So, it is not longer needed.
>
> Reviewed-by: Petr Mladek <[email protected]>
>
> Best Regards,
> Petr
>
> PS: I'll give it few days just in case anyone else would want to
> review it. I'll push it then unless anyone complains.
FWIW, looks good to me
Reviewed-by: Sergey Senozhatsky <[email protected]>
-ss
On Mon 2020-11-30 13:49:15, Lukas Bulwahn wrote:
> Commit 849f3127bb46 ("switch /dev/kmsg to ->write_iter()") refactored
> devkmsg_write() and left over a dead assignment on the variable 'len'.
>
> Hence, make clang-analyzer warns:
>
> kernel/printk/printk.c:744:4: warning: Value stored to 'len' is never read
> [clang-analyzer-deadcode.DeadStores]
> len -= endp - line;
> ^
>
> Simply remove this obsolete dead assignment here.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
The patch is committed in printk/linux.git, branch for-5.11.
Best Regards,
Petr