2005-04-05 15:25:36

by James Morris

[permalink] [raw]
Subject: [PATCH] SELinux: fix bug in Netlink message type detection

This patch fixes a bug in the SELinux Netlink message type detection code,
where the wrong constant was being used in a case statement. The incorrect
value is not valid for this class of object so it would not have been reached,
and fallen through to a default handler for all Netlink messages.

Please apply.


Signed-off-by: James Morris <[email protected]>
Signed-off-by: Stephen Smalley <[email protected]>

---

security/selinux/nlmsgtab.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)


diff -urN -X dontdiff linux-2.6.12-rc1-mm4.o/security/selinux/nlmsgtab.c linux-2.6.12-rc1-mm4.w/security/selinux/nlmsgtab.c
--- linux-2.6.12-rc1-mm4.o/security/selinux/nlmsgtab.c 2005-03-15 19:17:05.000000000 -0500
+++ linux-2.6.12-rc1-mm4.w/security/selinux/nlmsgtab.c 2005-04-04 18:57:55.000000000 -0400
@@ -126,7 +126,7 @@
break;

case SECCLASS_NETLINK_FIREWALL_SOCKET:
- case NETLINK_IP6_FW:
+ case SECCLASS_NETLINK_IP6FW_SOCKET:
err = nlmsg_perm(nlmsg_type, perm, nlmsg_firewall_perms,
sizeof(nlmsg_firewall_perms));
break;