2008-06-28 23:56:29

by Hugh Dickins

[permalink] [raw]
Subject: [PATCH trivial] security: remove unused forwards

Why would linux/security.h need forward declarations for nfsctl_arg
and swap_info_struct? It's hard to imagine: remove them.

Signed-off-by: Hugh Dickins <[email protected]>
---

include/linux/security.h | 2 --
1 file changed, 2 deletions(-)

--- linux-next/include/linux/security.h 2008-06-27 13:39:19.000000000 +0100
+++ linux/include/linux/security.h 2008-06-27 14:08:00.000000000 +0100
@@ -101,9 +101,7 @@ extern unsigned long mmap_min_addr;
#define LSM_SETID_FS 8

/* forward declares to avoid warnings */
-struct nfsctl_arg;
struct sched_param;
-struct swap_info_struct;
struct request_sock;

/* bprm_apply_creds unsafe reasons */


2008-06-30 11:00:18

by James Morris

[permalink] [raw]
Subject: Re: [PATCH trivial] security: remove unused forwards

On Sun, 29 Jun 2008, Hugh Dickins wrote:

> Why would linux/security.h need forward declarations for nfsctl_arg
> and swap_info_struct? It's hard to imagine: remove them.

Probably for some removed and long-forgotten security hooks.

>
> Signed-off-by: Hugh Dickins <[email protected]>
> ---

Acked-by: James Morris <[email protected]>


--
James Morris
<[email protected]>