Add missing reg property and update example to add dsi top node.
Fixes: ef85db911134 ("dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel")
Signed-off-by: Neil Armstrong <[email protected]>
---
.../bindings/display/panel/visionox,vtdr6130.yaml | 34 ++++++++++++++--------
1 file changed, 22 insertions(+), 12 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
index 49e2fd4b4e99..84562a5b710a 100644
--- a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
+++ b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
@@ -16,6 +16,10 @@ properties:
compatible:
const: visionox,vtdr6130
+ reg:
+ maxItems: 1
+ description: DSI virtual channel
+
vddio-supply: true
vci-supply: true
vdd-supply: true
@@ -26,6 +30,7 @@ additionalProperties: false
required:
- compatible
+ - reg
- vddio-supply
- vci-supply
- vdd-supply
@@ -35,18 +40,23 @@ required:
examples:
- |
#include <dt-bindings/gpio/gpio.h>
- panel {
- compatible = "visionox,vtdr6130";
-
- vddio-supply = <&vreg_l12b_1p8>;
- vci-supply = <&vreg_l13b_3p0>;
- vdd-supply = <&vreg_l11b_1p2>;
-
- reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
-
- port {
- panel0_in: endpoint {
- remote-endpoint = <&dsi0_out>;
+ dsi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ panel@0 {
+ compatible = "visionox,vtdr6130";
+ reg = <0>;
+
+ vddio-supply = <&vreg_l12b_1p8>;
+ vci-supply = <&vreg_l13b_3p0>;
+ vdd-supply = <&vreg_l11b_1p2>;
+
+ reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
+
+ port {
+ panel0_in: endpoint {
+ remote-endpoint = <&dsi0_out>;
+ };
};
};
};
---
base-commit: 49a8133221c71b935f36a7c340c0271c2a9ee2db
change-id: 20230207-topic-sm8550-upstream-vtdr6130-bindings-fix-a1d2630efc06
Best regards,
--
Neil Armstrong <[email protected]>
On 07/02/2023 11:04, Neil Armstrong wrote:
> Add missing reg property and update example to add dsi top node.
>
> Fixes: ef85db911134 ("dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel")
> Signed-off-by: Neil Armstrong <[email protected]>
> ---
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
Hi Neil.
On Tue, Feb 07, 2023 at 11:04:36AM +0100, Neil Armstrong wrote:
> Add missing reg property and update example to add dsi top node.
>
> Fixes: ef85db911134 ("dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel")
> Signed-off-by: Neil Armstrong <[email protected]>
> ---
> .../bindings/display/panel/visionox,vtdr6130.yaml | 34 ++++++++++++++--------
> 1 file changed, 22 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
> index 49e2fd4b4e99..84562a5b710a 100644
> --- a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
> @@ -16,6 +16,10 @@ properties:
> compatible:
> const: visionox,vtdr6130
>
> + reg:
> + maxItems: 1
> + description: DSI virtual channel
> +
Other panels using dsi uses a simple
" reg: true"
I think that would suffice here too.
Sam
On Tue, Feb 07, 2023 at 07:36:00PM +0100, Sam Ravnborg wrote:
> Hi Neil.
>
>
> On Tue, Feb 07, 2023 at 11:04:36AM +0100, Neil Armstrong wrote:
> > Add missing reg property and update example to add dsi top node.
> >
> > Fixes: ef85db911134 ("dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel")
> > Signed-off-by: Neil Armstrong <[email protected]>
> > ---
> > .../bindings/display/panel/visionox,vtdr6130.yaml | 34 ++++++++++++++--------
> > 1 file changed, 22 insertions(+), 12 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
> > index 49e2fd4b4e99..84562a5b710a 100644
> > --- a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
> > @@ -16,6 +16,10 @@ properties:
> > compatible:
> > const: visionox,vtdr6130
> >
> > + reg:
> > + maxItems: 1
> > + description: DSI virtual channel
> > +
> Other panels using dsi uses a simple
> " reg: true"
>
> I think that would suffice here too.
Yes, because dsi-controller.yaml restricts it to a single entry.
However, it's description says there can be more than 1 virtual channel
for a device. In that case, it shouldn't be restricted in
dsi-controller.yaml and the above with 'maxItems: 1' would be correct.
So I'd keep this as-is.
Acked-by: Rob Herring <[email protected]>
Rob
On Tue, Feb 07, 2023 at 02:37:16PM -0600, Rob Herring wrote:
> On Tue, Feb 07, 2023 at 07:36:00PM +0100, Sam Ravnborg wrote:
> > Hi Neil.
> >
> >
> > On Tue, Feb 07, 2023 at 11:04:36AM +0100, Neil Armstrong wrote:
> > > Add missing reg property and update example to add dsi top node.
> > >
> > > Fixes: ef85db911134 ("dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel")
> > > Signed-off-by: Neil Armstrong <[email protected]>
> > > ---
> > > .../bindings/display/panel/visionox,vtdr6130.yaml | 34 ++++++++++++++--------
> > > 1 file changed, 22 insertions(+), 12 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
> > > index 49e2fd4b4e99..84562a5b710a 100644
> > > --- a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
> > > +++ b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
> > > @@ -16,6 +16,10 @@ properties:
> > > compatible:
> > > const: visionox,vtdr6130
> > >
> > > + reg:
> > > + maxItems: 1
> > > + description: DSI virtual channel
> > > +
> > Other panels using dsi uses a simple
> > " reg: true"
> >
> > I think that would suffice here too.
>
> Yes, because dsi-controller.yaml restricts it to a single entry.
> However, it's description says there can be more than 1 virtual channel
> for a device. In that case, it shouldn't be restricted in
> dsi-controller.yaml and the above with 'maxItems: 1' would be correct.
> So I'd keep this as-is.
Thanks for the explanation.
>
> Acked-by: Rob Herring <[email protected]>
Acked-by: Sam Ravnborg <[email protected]>
Hi,
On Tue, 07 Feb 2023 11:04:36 +0100, Neil Armstrong wrote:
> Add missing reg property and update example to add dsi top node.
>
>
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next-fixes)
[1/1] dt-bindings: display: panel: visionox,vtdr6130: add missing reg property
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=467fbc77f673ecc9dcf4e58ffc1fa426a22df7fd
--
Neil