2023-02-08 16:10:49

by Clément Léger

Subject: [PATCH net-next] net: pcs: rzn1-miic: remove unused struct members and use miic variable

Remove unused bulk clocks struct from the miic state and use an already
existing miic variable in miic_config().

Signed-off-by: Clément Léger <[email protected]>
---
drivers/net/pcs/pcs-rzn1-miic.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c
index c1424119e821..323bec5e57f8 100644
--- a/drivers/net/pcs/pcs-rzn1-miic.c
+++ b/drivers/net/pcs/pcs-rzn1-miic.c
@@ -121,15 +121,11 @@ static const char *index_to_string[MIIC_MODCTRL_CONF_CONV_NUM] = {
* struct miic - MII converter structure
* @base: base address of the MII converter
* @dev: Device associated to the MII converter
- * @clks: Clocks used for this device
- * @nclk: Number of clocks
* @lock: Lock used for read-modify-write access
*/
struct miic {
void __iomem *base;
struct device *dev;
- struct clk_bulk_data *clks;
- int nclk;
spinlock_t lock;
};

@@ -232,7 +228,7 @@ static int miic_config(struct phylink_pcs *pcs, unsigned int mode,
}

miic_reg_rmw(miic, MIIC_CONVCTRL(port), mask, val);
- miic_converter_enable(miic_port->miic, miic_port->port, 1);
+ miic_converter_enable(miic, miic_port->port, 1);

return 0;
}
--
2.39.0

2023-02-10 06:50:25

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] net: pcs: rzn1-miic: remove unused struct members and use miic variable

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Wed, 8 Feb 2023 17:12:49 +0100 you wrote:
> Remove unused bulk clocks struct from the miic state and use an already
> existing miic variable in miic_config().
>
> Signed-off-by: Clément Léger <[email protected]>
> ---
> drivers/net/pcs/pcs-rzn1-miic.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)

Here is the summary with links:
- [net-next] net: pcs: rzn1-miic: remove unused struct members and use miic variable
https://git.kernel.org/netdev/net-next/c/dc8c41320130

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

2023-02-10 11:05:30

by Russell King (Oracle)

Subject: Re: [PATCH net-next] net: pcs: rzn1-miic: remove unused struct members and use miic variable

On Wed, Feb 08, 2023 at 05:12:49PM +0100, Cl?ment L?ger wrote:
> Remove unused bulk clocks struct from the miic state and use an already
> existing miic variable in miic_config().
>
> Signed-off-by: Cl?ment L?ger <[email protected]>

Reviewed-by: Russell King (Oracle) <[email protected]>

Thanks.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!