2022-10-18 12:05:06

by Tanjuate Brunostar

Subject: [PATCH v2] staging: rts5208: split long line of code

Fix checkpatch warning by splitting up a long line of code, improving
code readability

Signed-off-by: Tanjuate Brunostar <[email protected]>
---

v2: Reorganized the line of code by splitting it where it does not break
the parenthesis as recommended by Julia Lawall

drivers/staging/rts5208/sd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
index 4643127a87ca..74c4f476b3a4 100644
--- a/drivers/staging/rts5208/sd.c
+++ b/drivers/staging/rts5208/sd.c
@@ -4505,7 +4505,8 @@ int sd_execute_write_data(struct scsi_cmnd *srb, struct rtsx_chip *chip)
if (CHK_SD(sd_card)) {
retval = reset_sd(chip);
if (retval != STATUS_SUCCESS) {
- sd_card->sd_lock_status &= ~(SD_UNLOCK_POW_ON | SD_SDR_RST);
+ sd_card->sd_lock_status &=
+ ~(SD_UNLOCK_POW_ON | SD_SDR_RST);
goto sd_execute_write_cmd_failed;
}
}
--
2.34.1

2022-10-18 12:22:07

by Julia Lawall

Subject: Re: [PATCH v2] staging: rts5208: split long line of code

On Tue, 18 Oct 2022, Tanjuate Brunostar wrote:

> Fix checkpatch warning by splitting up a long line of code, improving
> code readability
>
> Signed-off-by: Tanjuate Brunostar <[email protected]>

Acked-by: Julia Lawall <[email protected]>

> ---
>
> v2: Reorganized the line of code by splitting it where it does not break
> the parenthesis as recommended by Julia Lawall
>
> drivers/staging/rts5208/sd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
> index 4643127a87ca..74c4f476b3a4 100644
> --- a/drivers/staging/rts5208/sd.c
> +++ b/drivers/staging/rts5208/sd.c
> @@ -4505,7 +4505,8 @@ int sd_execute_write_data(struct scsi_cmnd *srb, struct rtsx_chip *chip)
> if (CHK_SD(sd_card)) {
> retval = reset_sd(chip);
> if (retval != STATUS_SUCCESS) {
> - sd_card->sd_lock_status &= ~(SD_UNLOCK_POW_ON | SD_SDR_RST);
> + sd_card->sd_lock_status &=
> + ~(SD_UNLOCK_POW_ON | SD_SDR_RST);
> goto sd_execute_write_cmd_failed;
> }
> }
> --
> 2.34.1
>
>
>