2022-10-11 03:00:58

by ye xingchen

Subject: [PATCH linux-next] vsprintf: replace in_irq() with in_hardirq()

From: ye xingchen <[email protected]>

Replace the obsolete and ambiguos macro in_irq() with new
macro in_hardirq().

Signed-off-by: ye xingchen <[email protected]>
---
lib/vsprintf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 24f37bab8bc1..5b0611c00956 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -866,7 +866,7 @@ char *restricted_pointer(char *buf, char *end, const void *ptr,
* kptr_restrict==1 cannot be used in IRQ context
* because its test for CAP_SYSLOG would be meaningless.
*/
- if (in_irq() || in_serving_softirq() || in_nmi()) {
+ if (in_hardirq() || in_serving_softirq() || in_nmi()) {
if (spec.field_width == -1)
spec.field_width = 2 * sizeof(ptr);
return error_string(buf, end, "pK-error", spec);
--
2.25.1

2022-10-11 03:44:58

by Sergey Senozhatsky

Subject: Re: [PATCH linux-next] vsprintf: replace in_irq() with in_hardirq()

On (22/10/11 02:48), [email protected] wrote:
> Replace the obsolete and ambiguos macro in_irq() with new
> macro in_hardirq().
>
> Signed-off-by: ye xingchen <[email protected]>

Per 15115830c8875 in_irq() is "obsolete".

FWIW,
Reviewed-by: Sergey Senozhatsky <[email protected]>

2022-10-11 09:05:00

by Petr Mladek

Subject: Re: [PATCH linux-next] vsprintf: replace in_irq() with in_hardirq()

On Tue 2022-10-11 02:48:31, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Replace the obsolete and ambiguos macro in_irq() with new
> macro in_hardirq().
>
> Signed-off-by: ye xingchen <[email protected]>

Reviewed-by: Petr Mladek <[email protected]>

I am going to queue it for 6.2. I would push it for 6.1 only together
with another important changes. This one is not worth pull request
at this stage.

Best Regards,
Petr

2022-10-18 14:51:21

by Petr Mladek

Subject: Re: [PATCH linux-next] vsprintf: replace in_irq() with in_hardirq()

On Tue 2022-10-11 11:02:38, Petr Mladek wrote:
> On Tue 2022-10-11 02:48:31, [email protected] wrote:
> > From: ye xingchen <[email protected]>
> >
> > Replace the obsolete and ambiguos macro in_irq() with new
> > macro in_hardirq().
> >
> > Signed-off-by: ye xingchen <[email protected]>
>
> Reviewed-by: Petr Mladek <[email protected]>
>
> I am going to queue it for 6.2. I would push it for 6.1 only together
> with another important changes. This one is not worth pull request
> at this stage.

JFYI, the patch is committed in printk/linux.git, branch for-6.2.

Best Regards,
Petr