2022-10-11 03:45:15

by ye xingchen

[permalink] [raw]
Subject: [PATCH linux-next] soc: Use generic_handle_domain_irq()

From: ye xingchen <[email protected]>

Replace generic_handle_irq(irq_find_mapping()) with
generic_handle_domain_irq().

Signed-off-by: ye xingchen <[email protected]>
---
drivers/soc/dove/pmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/dove/pmu.c b/drivers/soc/dove/pmu.c
index ffc5311c0ed8..308fe45231b4 100644
--- a/drivers/soc/dove/pmu.c
+++ b/drivers/soc/dove/pmu.c
@@ -243,7 +243,7 @@ static void pmu_irq_handler(struct irq_desc *desc)
stat &= ~(1 << hwirq);
done &= ~(1 << hwirq);

- generic_handle_irq(irq_find_mapping(domain, hwirq));
+ generic_handle_domain_irq(domain, hwirq);
}

/*
--
2.25.1


2022-10-11 04:39:55

by Mukesh Ojha

[permalink] [raw]
Subject: Re: [PATCH linux-next] soc: Use generic_handle_domain_irq()

Hi,

On 10/11/2022 8:50 AM, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Replace generic_handle_irq(irq_find_mapping()) with
> generic_handle_domain_irq().
>
> Signed-off-by: ye xingchen <[email protected]>
> ---
> drivers/soc/dove/pmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/dove/pmu.c b/drivers/soc/dove/pmu.c
> index ffc5311c0ed8..308fe45231b4 100644
> --- a/drivers/soc/dove/pmu.c
> +++ b/drivers/soc/dove/pmu.c
> @@ -243,7 +243,7 @@ static void pmu_irq_handler(struct irq_desc *desc)
> stat &= ~(1 << hwirq);
> done &= ~(1 << hwirq);
>
> - generic_handle_irq(irq_find_mapping(domain, hwirq));
> + generic_handle_domain_irq(domain, hwirq);

Thanks.

Reviewed-By : Mukesh Ojha <[email protected]>

-Mukesh


> }
>
> /*

2022-10-11 13:17:12

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH linux-next] soc: Use generic_handle_domain_irq()

On Tue, Oct 11, 2022 at 03:20:50AM +0000, [email protected] wrote:
> From: ye xingchen <[email protected]>

Please make your subject line more specific. soc: dove: would be
better.

/linux/drivers/soc/dove$ git log --oneline .
ec8f24b7faaf treewide: Add SPDX license identifier - Makefile/Kconfig
dc37a2525271 soc: Convert to using %pOFn instead of device_node.name
b24413180f56 License cleanup: add SPDX GPL-2.0 license identifier to files with no license
f2591b993ec9 soc: dove: constify reset_control_ops structures
67098119abeb soc: dove: add legacy support to PMU driver
2376692416b7 soc: dove: Let genpd deal with disabling of unused PM domains
bd0b9ac405e1 genirq: Remove irq argument from irq flow handlers
b838c950b397 soc: dove: Prepare irq handler for irq argument removal
5230347ea70a soc: dove: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc
44e259ac909f ARM: dove: create a proper PMU driver for power domains, PMU IRQs and resets

dove is an important keyword to get the right people to look at your
patch. Few people are interested in soc, they are interested in a
specific devices within soc.

>
> Replace generic_handle_irq(irq_find_mapping()) with
> generic_handle_domain_irq().
>
> Signed-off-by: ye xingchen <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew