2022-10-20 08:50:54

by Dan Carpenter

Subject: Re: [PATCH v3 05/10] staging: r8188eu: correct misspelled words in comments

On Thu, Oct 20, 2022 at 01:25:16PM +0530, Deepak R Varma wrote:
> diff --git a/drivers/staging/r8188eu/core/rtw_ioctl_set.c b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> index 55e6b0f41dc3..1de808832ed8 100644
> --- a/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> +++ b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> @@ -287,7 +287,7 @@ u8 rtw_set_802_11_infrastructure_mode(struct adapter *padapter,
>
> if ((*pold_state == Ndis802_11Infrastructure) || (*pold_state == Ndis802_11IBSS)) {
> if (check_fwstate(pmlmepriv, _FW_LINKED))
> - rtw_indicate_disconnect(padapter); /* will clr Linked_state; before this function, we must have chked whether issue dis-assoc_cmd or not */
> + rtw_indicate_disconnect(padapter); /* will clr Linked_state; before this function, we must have cheked whether issue dis-assoc_cmd or not */


s/cheked/checked/

> }
>
> *pold_state = networktype;

regards,
dan carpenter

2022-10-20 09:15:41

by Deepak R Varma

Subject: Re: [PATCH v3 05/10] staging: r8188eu: correct misspelled words in comments

On Thu, Oct 20, 2022 at 11:22:10AM +0300, Dan Carpenter wrote:
> On Thu, Oct 20, 2022 at 01:25:16PM +0530, Deepak R Varma wrote:
> > diff --git a/drivers/staging/r8188eu/core/rtw_ioctl_set.c b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> > index 55e6b0f41dc3..1de808832ed8 100644
> > --- a/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> > +++ b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> > @@ -287,7 +287,7 @@ u8 rtw_set_802_11_infrastructure_mode(struct adapter *padapter,
> >
> > if ((*pold_state == Ndis802_11Infrastructure) || (*pold_state == Ndis802_11IBSS)) {
> > if (check_fwstate(pmlmepriv, _FW_LINKED))
> > - rtw_indicate_disconnect(padapter); /* will clr Linked_state; before this function, we must have chked whether issue dis-assoc_cmd or not */
> > + rtw_indicate_disconnect(padapter); /* will clr Linked_state; before this function, we must have cheked whether issue dis-assoc_cmd or not */
>
>
> s/cheked/checked/

ahhh... That's insane. I must have overlooked the code-spell indication. Thank you for
catching it Dan. I will wait for feedback on other patches and accordingly send
in the revised version.

./drv

>
> > }
> >
> > *pold_state = networktype;
>
> regards,
> dan carpenter

2022-10-20 09:50:35

by Julia Lawall

Subject: Re: [PATCH v3 05/10] staging: r8188eu: correct misspelled words in comments

On Thu, 20 Oct 2022, Dan Carpenter wrote:

> On Thu, Oct 20, 2022 at 01:25:16PM +0530, Deepak R Varma wrote:
> > diff --git a/drivers/staging/r8188eu/core/rtw_ioctl_set.c b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> > index 55e6b0f41dc3..1de808832ed8 100644
> > --- a/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> > +++ b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> > @@ -287,7 +287,7 @@ u8 rtw_set_802_11_infrastructure_mode(struct adapter *padapter,
> >
> > if ((*pold_state == Ndis802_11Infrastructure) || (*pold_state == Ndis802_11IBSS)) {
> > if (check_fwstate(pmlmepriv, _FW_LINKED))
> > - rtw_indicate_disconnect(padapter); /* will clr Linked_state; before this function, we must have chked whether issue dis-assoc_cmd or not */
> > + rtw_indicate_disconnect(padapter); /* will clr Linked_state; before this function, we must have cheked whether issue dis-assoc_cmd or not */
>
>
> s/cheked/checked/

There is also a strange double space before issue.

julia

>
> > }
> >
> > *pold_state = networktype;
>
> regards,
> dan carpenter
>
>