2022-10-21 10:42:12

by Deepak R Varma

Subject: [PATCH] staging: wlan-ng: remove commented debug printk messages

printk messages are added for program flow tracing and are left
commented. These commented log messages should be removed as they
are no more useful for program execution.

Signed-off-by: Deepak R Varma <[email protected]>
---
drivers/staging/wlan-ng/p80211netdev.c | 22 ----------------------
1 file changed, 22 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
index e04fc666d218..6bef419e8ad0 100644
--- a/drivers/staging/wlan-ng/p80211netdev.c
+++ b/drivers/staging/wlan-ng/p80211netdev.c
@@ -881,55 +881,42 @@ static int p80211_rx_typedrop(struct wlandevice *wlandev, u16 fc)
wlandev->rx.mgmt++;
switch (fstype) {
case WLAN_FSTYPE_ASSOCREQ:
- /* printk("assocreq"); */
wlandev->rx.assocreq++;
break;
case WLAN_FSTYPE_ASSOCRESP:
- /* printk("assocresp"); */
wlandev->rx.assocresp++;
break;
case WLAN_FSTYPE_REASSOCREQ:
- /* printk("reassocreq"); */
wlandev->rx.reassocreq++;
break;
case WLAN_FSTYPE_REASSOCRESP:
- /* printk("reassocresp"); */
wlandev->rx.reassocresp++;
break;
case WLAN_FSTYPE_PROBEREQ:
- /* printk("probereq"); */
wlandev->rx.probereq++;
break;
case WLAN_FSTYPE_PROBERESP:
- /* printk("proberesp"); */
wlandev->rx.proberesp++;
break;
case WLAN_FSTYPE_BEACON:
- /* printk("beacon"); */
wlandev->rx.beacon++;
break;
case WLAN_FSTYPE_ATIM:
- /* printk("atim"); */
wlandev->rx.atim++;
break;
case WLAN_FSTYPE_DISASSOC:
- /* printk("disassoc"); */
wlandev->rx.disassoc++;
break;
case WLAN_FSTYPE_AUTHEN:
- /* printk("authen"); */
wlandev->rx.authen++;
break;
case WLAN_FSTYPE_DEAUTHEN:
- /* printk("deauthen"); */
wlandev->rx.deauthen++;
break;
default:
- /* printk("unknown"); */
wlandev->rx.mgmt_unknown++;
break;
}
- /* printk("\n"); */
drop = 2;
break;

@@ -943,35 +930,27 @@ static int p80211_rx_typedrop(struct wlandevice *wlandev, u16 fc)
wlandev->rx.ctl++;
switch (fstype) {
case WLAN_FSTYPE_PSPOLL:
- /* printk("pspoll"); */
wlandev->rx.pspoll++;
break;
case WLAN_FSTYPE_RTS:
- /* printk("rts"); */
wlandev->rx.rts++;
break;
case WLAN_FSTYPE_CTS:
- /* printk("cts"); */
wlandev->rx.cts++;
break;
case WLAN_FSTYPE_ACK:
- /* printk("ack"); */
wlandev->rx.ack++;
break;
case WLAN_FSTYPE_CFEND:
- /* printk("cfend"); */
wlandev->rx.cfend++;
break;
case WLAN_FSTYPE_CFENDCFACK:
- /* printk("cfendcfack"); */
wlandev->rx.cfendcfack++;
break;
default:
- /* printk("unknown"); */
wlandev->rx.ctl_unknown++;
break;
}
- /* printk("\n"); */
drop = 2;
break;

@@ -1007,7 +986,6 @@ static int p80211_rx_typedrop(struct wlandevice *wlandev, u16 fc)
wlandev->rx.cfack_cfpoll++;
break;
default:
- /* printk("unknown"); */
wlandev->rx.data_unknown++;
break;
}
--
2.30.2

2022-10-22 10:02:12

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: wlan-ng: remove commented debug printk messages

On Fri, Oct 21, 2022 at 07:15:24AM +0530, Deepak R Varma wrote:
> printk messages are added for program flow tracing and are left
> commented. These commented log messages should be removed as they
> are no more useful for program execution.
>
> Signed-off-by: Deepak R Varma <[email protected]>
> ---
> drivers/staging/wlan-ng/p80211netdev.c | 22 ----------------------
> 1 file changed, 22 deletions(-)

I recieved 3 different copies of this patch, and do not know which one
to take at all.

So please resend this as a v2 patch, only once, and I will be glad to
review it.

thanks,

greg k-h

2022-10-22 20:38:45

by Deepak R Varma

Subject: Re: [PATCH] staging: wlan-ng: remove commented debug printk messages

On Sat, Oct 22, 2022 at 09:58:09AM +0200, Greg KH wrote:
> On Fri, Oct 21, 2022 at 07:15:24AM +0530, Deepak R Varma wrote:
> > printk messages are added for program flow tracing and are left
> > commented. These commented log messages should be removed as they
> > are no more useful for program execution.
> >
> > Signed-off-by: Deepak R Varma <[email protected]>
> > ---
> > drivers/staging/wlan-ng/p80211netdev.c | 22 ----------------------
> > 1 file changed, 22 deletions(-)
>
> I recieved 3 different copies of this patch, and do not know which one
> to take at all.

Hello Greg,
My apologies for the spam. There have been some trouble with my email
transactions. I was unable to see my own email and hence ended up resending the
same patch 3 times.

>
> So please resend this as a v2 patch, only once, and I will be glad to
> review it.

Sure and thank you very much. Will send in v2 shortly.

./drv

>
> thanks,
>
> greg k-h