2022-10-19 15:09:06

by John Ogness

Subject: [PATCH printk v2 07/38] um: kmsg_dump: use console_is_enabled()

Replace (console->flags & CON_ENABLED) usage with console_is_enabled().

Signed-off-by: John Ogness <[email protected]>
---
arch/um/kernel/kmsg_dump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/um/kernel/kmsg_dump.c b/arch/um/kernel/kmsg_dump.c
index 0224fcb36e22..3a3bbbb22090 100644
--- a/arch/um/kernel/kmsg_dump.c
+++ b/arch/um/kernel/kmsg_dump.c
@@ -22,8 +22,8 @@ static void kmsg_dumper_stdout(struct kmsg_dumper *dumper,
return;

for_each_console(con) {
- if(strcmp(con->name, "tty") == 0 &&
- (con->flags & (CON_ENABLED | CON_CONSDEV)) != 0) {
+ if (strcmp(con->name, "tty") == 0 &&
+ (console_is_enabled(con) || (con->flags & CON_CONSDEV))) {
break;
}
}
--
2.30.2

2022-10-21 13:40:46

by Petr Mladek

Subject: Re: [PATCH printk v2 07/38] um: kmsg_dump: use console_is_enabled()

On Wed 2022-10-19 17:01:29, John Ogness wrote:
> Replace (console->flags & CON_ENABLED) usage with console_is_enabled().
>
> Signed-off-by: John Ogness <[email protected]>

Reviewed-by: Petr Mladek <[email protected]>

Best Regards,
Petr