2022-09-30 14:58:29

by Patrice CHOTARD

Subject: [PATCH v3] usb: dwc3: st: Rely on child's compatible instead of name

From: Patrice Chotard <[email protected]>

To ensure that child node is found, don't rely on child's node name
which can take different value, but on child's compatible name.

Fixes: f5c5936d6b4d ("usb: dwc3: st: Fix node's child name")
Cc: Jerome Audu <[email protected]>
Reported-by: Felipe Balbi <[email protected]>
Signed-off-by: Patrice Chotard <[email protected]>
---
v3: - rebase on correct branch
v2: - add missing reported-by
- add Fixes
---
drivers/usb/dwc3/dwc3-st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
index 6c14a79279f9..fea5290de83f 100644
--- a/drivers/usb/dwc3/dwc3-st.c
+++ b/drivers/usb/dwc3/dwc3-st.c
@@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
/* Manage SoftReset */
reset_control_deassert(dwc3_data->rstc_rst);

- child = of_get_child_by_name(node, "usb");
+ child = of_get_compatible_child(node, "snps,dwc3");
if (!child) {
dev_err(&pdev->dev, "failed to find dwc3 core node\n");
ret = -ENODEV;
--
2.25.1

2022-10-22 11:41:06

by Greg Kroah-Hartman

Subject: Re: [PATCH v3] usb: dwc3: st: Rely on child's compatible instead of name

On Fri, Sep 30, 2022 at 04:20:18PM +0200, [email protected] wrote:
> From: Patrice Chotard <[email protected]>
>
> To ensure that child node is found, don't rely on child's node name
> which can take different value, but on child's compatible name.
>
> Fixes: f5c5936d6b4d ("usb: dwc3: st: Fix node's child name")
> Cc: Jerome Audu <[email protected]>
> Reported-by: Felipe Balbi <[email protected]>
> Signed-off-by: Patrice Chotard <[email protected]>
> ---
> v3: - rebase on correct branch
> v2: - add missing reported-by
> - add Fixes
> ---
> drivers/usb/dwc3/dwc3-st.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
> index 6c14a79279f9..fea5290de83f 100644
> --- a/drivers/usb/dwc3/dwc3-st.c
> +++ b/drivers/usb/dwc3/dwc3-st.c
> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
> /* Manage SoftReset */
> reset_control_deassert(dwc3_data->rstc_rst);
>
> - child = of_get_child_by_name(node, "usb");
> + child = of_get_compatible_child(node, "snps,dwc3");
> if (!child) {
> dev_err(&pdev->dev, "failed to find dwc3 core node\n");
> ret = -ENODEV;
> --
> 2.25.1
>

Is this still needed for 6.1-final?

thanks,

greg k-h

2022-10-24 07:24:04

by Patrice CHOTARD

Subject: Re: [PATCH v3] usb: dwc3: st: Rely on child's compatible instead of name

On 10/22/22 12:26, Greg Kroah-Hartman wrote:
> On Fri, Sep 30, 2022 at 04:20:18PM +0200, [email protected] wrote:
>> From: Patrice Chotard <[email protected]>
>>
>> To ensure that child node is found, don't rely on child's node name
>> which can take different value, but on child's compatible name.
>>
>> Fixes: f5c5936d6b4d ("usb: dwc3: st: Fix node's child name")
>> Cc: Jerome Audu <[email protected]>
>> Reported-by: Felipe Balbi <[email protected]>
>> Signed-off-by: Patrice Chotard <[email protected]>
>> ---
>> v3: - rebase on correct branch
>> v2: - add missing reported-by
>> - add Fixes
>> ---
>> drivers/usb/dwc3/dwc3-st.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
>> index 6c14a79279f9..fea5290de83f 100644
>> --- a/drivers/usb/dwc3/dwc3-st.c
>> +++ b/drivers/usb/dwc3/dwc3-st.c
>> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
>> /* Manage SoftReset */
>> reset_control_deassert(dwc3_data->rstc_rst);
>>
>> - child = of_get_child_by_name(node, "usb");
>> + child = of_get_compatible_child(node, "snps,dwc3");
>> if (!child) {
>> dev_err(&pdev->dev, "failed to find dwc3 core node\n");
>> ret = -ENODEV;
>> --
>> 2.25.1
>>
>
> Is this still needed for 6.1-final?

Yes, still needed for v6.1.

Thanks
Patrice

>
> thanks,
>
> greg k-h