2022-10-22 21:55:43

by Oded Gabbay

[permalink] [raw]
Subject: [RFC PATCH 1/3] drivers/accel: add new kconfig and update MAINTAINERS

Add a new Kconfig for the accel subsystem. The Kconfig currently
contains only the basic CONFIG_ACCEL option that will be used to
decide whether to compile the accel registration code as part of the
drm core functionality.

I have taken the liberty to appropriate the dri-devel mailing list and
the dri-devel IRC channel for the accel subsystem.

Signed-off-by: Oded Gabbay <[email protected]>
---
MAINTAINERS | 8 ++++++++
drivers/Kconfig | 2 ++
drivers/accel/Kconfig | 24 ++++++++++++++++++++++++
3 files changed, 34 insertions(+)
create mode 100644 drivers/accel/Kconfig

diff --git a/MAINTAINERS b/MAINTAINERS
index cf0f18502372..790d472801d5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6820,6 +6820,14 @@ F: include/drm/drm*
F: include/linux/vga*
F: include/uapi/drm/drm*

+DRM COMPUTE ACCELERATORS DRIVERS AND FRAMEWORK
+M: Oded Gabbay <[email protected]>
+L: [email protected]
+S: Maintained
+C: irc://irc.oftc.net/dri-devel
+T: git https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git
+F: drivers/accel/
+
DRM DRIVERS FOR ALLWINNER A10
M: Maxime Ripard <[email protected]>
M: Chen-Yu Tsai <[email protected]>
diff --git a/drivers/Kconfig b/drivers/Kconfig
index 19ee995bd0ae..968bd0a6fd78 100644
--- a/drivers/Kconfig
+++ b/drivers/Kconfig
@@ -99,6 +99,8 @@ source "drivers/media/Kconfig"

source "drivers/video/Kconfig"

+source "drivers/accel/Kconfig"
+
source "sound/Kconfig"

source "drivers/hid/Kconfig"
diff --git a/drivers/accel/Kconfig b/drivers/accel/Kconfig
new file mode 100644
index 000000000000..282ea24f90c5
--- /dev/null
+++ b/drivers/accel/Kconfig
@@ -0,0 +1,24 @@
+# SPDX-License-Identifier: GPL-2.0-only
+#
+# Compute Acceleration device configuration
+#
+# This framework provides support for compute acceleration devices, such
+# as, but not limited to, Machine-Learning and Deep-Learning acceleration
+# devices
+#
+menuconfig ACCEL
+ tristate "Compute Acceleration Framework"
+ depends on DRM
+ help
+ Framework for device drivers of compute acceleration devices, such
+ as, but not limited to, Machine-Learning and Deep-Learning
+ acceleration devices.
+ If you say Y here, you need to select the module that's right for
+ your acceleration device from the list below.
+ This framework is integrated with the DRM subsystem as compute
+ accelerators and GPUs share a lot in common and can use almost the
+ same infrastructure code.
+ Having said that, acceleration devices will have a different
+ major number than GPUs, and will be exposed to user-space using
+ different device files, called accel/accel* (in /dev, sysfs
+ and debugfs)
--
2.34.1


2022-10-23 13:10:42

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [RFC PATCH 1/3] drivers/accel: add new kconfig and update MAINTAINERS

On Sun, Oct 23, 2022 at 12:46:20AM +0300, Oded Gabbay wrote:
> Add a new Kconfig for the accel subsystem. The Kconfig currently
> contains only the basic CONFIG_ACCEL option that will be used to
> decide whether to compile the accel registration code as part of the
> drm core functionality.
>
> I have taken the liberty to appropriate the dri-devel mailing list and
> the dri-devel IRC channel for the accel subsystem.
>
> Signed-off-by: Oded Gabbay <[email protected]>
> ---
> MAINTAINERS | 8 ++++++++
> drivers/Kconfig | 2 ++
> drivers/accel/Kconfig | 24 ++++++++++++++++++++++++

YOu never use drivers/accel/ again in this patch series, was that
intentional?

thanks,

greg k-h

2022-10-24 07:42:14

by Oded Gabbay

[permalink] [raw]
Subject: Re: [RFC PATCH 1/3] drivers/accel: add new kconfig and update MAINTAINERS

On Sun, Oct 23, 2022 at 3:40 PM Greg Kroah-Hartman
<[email protected]> wrote:
>
> On Sun, Oct 23, 2022 at 12:46:20AM +0300, Oded Gabbay wrote:
> > Add a new Kconfig for the accel subsystem. The Kconfig currently
> > contains only the basic CONFIG_ACCEL option that will be used to
> > decide whether to compile the accel registration code as part of the
> > drm core functionality.
> >
> > I have taken the liberty to appropriate the dri-devel mailing list and
> > the dri-devel IRC channel for the accel subsystem.
> >
> > Signed-off-by: Oded Gabbay <[email protected]>
> > ---
> > MAINTAINERS | 8 ++++++++
> > drivers/Kconfig | 2 ++
> > drivers/accel/Kconfig | 24 ++++++++++++++++++++++++
>
> YOu never use drivers/accel/ again in this patch series, was that
> intentional?
Yes, because I didn't plan for accel to have any core code at this stage.
But according to your other comments, this will probably change
(unless someone thinks otherwise).
Oded
>
> thanks,
>
> greg k-h

2022-10-24 20:13:45

by Jeffrey Hugo

[permalink] [raw]
Subject: Re: [RFC PATCH 1/3] drivers/accel: add new kconfig and update MAINTAINERS

On 10/22/2022 3:46 PM, Oded Gabbay wrote:
> Add a new Kconfig for the accel subsystem. The Kconfig currently
> contains only the basic CONFIG_ACCEL option that will be used to
> decide whether to compile the accel registration code as part of the
> drm core functionality.
>
> I have taken the liberty to appropriate the dri-devel mailing list and
> the dri-devel IRC channel for the accel subsystem.
>
> Signed-off-by: Oded Gabbay <[email protected]>
> ---
> MAINTAINERS | 8 ++++++++
> drivers/Kconfig | 2 ++
> drivers/accel/Kconfig | 24 ++++++++++++++++++++++++
> 3 files changed, 34 insertions(+)
> create mode 100644 drivers/accel/Kconfig
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index cf0f18502372..790d472801d5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6820,6 +6820,14 @@ F: include/drm/drm*
> F: include/linux/vga*
> F: include/uapi/drm/drm*
>
> +DRM COMPUTE ACCELERATORS DRIVERS AND FRAMEWORK
> +M: Oded Gabbay <[email protected]>
> +L: [email protected]
> +S: Maintained
> +C: irc://irc.oftc.net/dri-devel
> +T: git https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git
> +F: drivers/accel/

I'm willing to assist with reviews, etc. While I appreciate your
efforts to drive this, you shouldn't be taking on everything going
forward. Feel free to add me (or don't) to this entry as you see fit.