2022-10-24 08:37:18

by Quan Nguyen

Subject: [PATCH] ipmi: ssif_bmc: Use EPOLLIN instead of POLLIN

This fixes the following sparse warning:
sparse warnings: (new ones prefixed by >>)
>> drivers/char/ipmi/ssif_bmc.c:254:22: sparse: sparse: invalid assignment: |=
>> drivers/char/ipmi/ssif_bmc.c:254:22: sparse: left side has type restricted __poll_t
>> drivers/char/ipmi/ssif_bmc.c:254:22: sparse: right side has type int

Fixes: dd2bc5cc9e25 ("ipmi: ssif_bmc: Add SSIF BMC driver")
Reported-by: kernel test robot <[email protected]>
Link: https://lore.kernel.org/all/[email protected]/
Signed-off-by: Quan Nguyen <[email protected]>
---
drivers/char/ipmi/ssif_bmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
index a7bb4b99000e..2d8069386398 100644
--- a/drivers/char/ipmi/ssif_bmc.c
+++ b/drivers/char/ipmi/ssif_bmc.c
@@ -251,7 +251,7 @@ static __poll_t ssif_bmc_poll(struct file *file, poll_table *wait)
spin_lock_irq(&ssif_bmc->lock);
/* The request is available, userspace application can get the request */
if (ssif_bmc->request_available)
- mask |= POLLIN;
+ mask |= EPOLLIN;

spin_unlock_irq(&ssif_bmc->lock);

--
2.35.1

2022-10-24 16:06:46

by Corey Minyard

Subject: Re: [PATCH] ipmi: ssif_bmc: Use EPOLLIN instead of POLLIN

On Mon, Oct 24, 2022 at 02:59:56PM +0700, Quan Nguyen wrote:
> This fixes the following sparse warning:
> sparse warnings: (new ones prefixed by >>)
> >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse: sparse: invalid assignment: |=
> >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse: left side has type restricted __poll_t
> >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse: right side has type int

Thanks, you beat me to tracing this down. It's in my for-next queue.

-corey

>
> Fixes: dd2bc5cc9e25 ("ipmi: ssif_bmc: Add SSIF BMC driver")
> Reported-by: kernel test robot <[email protected]>
> Link: https://lore.kernel.org/all/[email protected]/
> Signed-off-by: Quan Nguyen <[email protected]>
> ---
> drivers/char/ipmi/ssif_bmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
> index a7bb4b99000e..2d8069386398 100644
> --- a/drivers/char/ipmi/ssif_bmc.c
> +++ b/drivers/char/ipmi/ssif_bmc.c
> @@ -251,7 +251,7 @@ static __poll_t ssif_bmc_poll(struct file *file, poll_table *wait)
> spin_lock_irq(&ssif_bmc->lock);
> /* The request is available, userspace application can get the request */
> if (ssif_bmc->request_available)
> - mask |= POLLIN;
> + mask |= EPOLLIN;
>
> spin_unlock_irq(&ssif_bmc->lock);
>
> --
> 2.35.1
>