The fixes are similar, mostly long lines splitting. I had to make
serveral patches to ease the work of inspectors
v2: fixed a compilation error found by the kernel test robot and
recompiled the code
v3: tends out the error persisted in the second version. this version is
a correction of that
v4: did some corrections as recommended by Greg KH
v5: shortend changelog comments as recommended by Greg KH
v6: did some corrections as recommended by Greg KH
v7: fixed some errors on my changelog comments
v8: fixed some errors pointed out by Philipp Hortmann
Tanjuate Brunostar (6):
staging: vt6655: fix lines ending in a '('
staging: vt6655: fix long lines of code in s_uGetRTSCTSDuration
staging: vt6655: fix long lines of code in s_uFillDataHead
staging: vt6655: fix long lines of code in s_vGenerateTxParamete
staging: vt6655: fix long lines of code in the rest of the file
staging: vt6655: fix lines of code ending in a '('
drivers/staging/vt6655/rxtx.c | 542 ++++++++++++++++++++--------------
1 file changed, 324 insertions(+), 218 deletions(-)
--
2.34.1
On Fri, Oct 28, 2022 at 05:40:52PM +0000, Tanjuate Brunostar wrote:
> The fixes are similar, mostly long lines splitting. I had to make
> serveral patches to ease the work of inspectors
>
> v2: fixed a compilation error found by the kernel test robot and
> recompiled the code
>
> v3: tends out the error persisted in the second version. this version is
> a correction of that
>
> v4: did some corrections as recommended by Greg KH
>
> v5: shortend changelog comments as recommended by Greg KH
>
> v6: did some corrections as recommended by Greg KH
>
> v7: fixed some errors on my changelog comments
>
> v8: fixed some errors pointed out by Philipp Hortmann
>
> Tanjuate Brunostar (6):
> staging: vt6655: fix lines ending in a '('
> staging: vt6655: fix long lines of code in s_uGetRTSCTSDuration
> staging: vt6655: fix long lines of code in s_uFillDataHead
> staging: vt6655: fix long lines of code in s_vGenerateTxParamete
> staging: vt6655: fix long lines of code in the rest of the file
> staging: vt6655: fix lines of code ending in a '('
>
You messed up your patchset...; the shortlog above says "fix longlines"
but individual patch subject says "refactor". Well, refactoring
means resturcturing and improving it without introducing new
functionality or changing behavior, which is really changing existing
code. However, your patchset only do visual formatting, right?
Also, have you ever at least compile-test your patchset (make W=1 and
enabling CONFIG_WERROR)?
Thanks.
--
An old man doll... just what I always wanted! - Clara