2022-10-27 20:12:03

by Nathan Chancellor

Subject: [PATCH -next] pinctrl: qcom: Include bitfield.h in pinctrl-lpass-lpi.c

When building ARCH=arm allmodconfig, the following error occurs:

drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function ‘lpi_gpio_set_mux’:
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:102:9: error: implicit declaration of function ‘u32p_replace_bits’ [-Werror=implicit-function-declaration]
102 | u32p_replace_bits(&val, i, LPI_GPIO_FUNCTION_MASK);
| ^~~~~~~~~~~~~~~~~
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function ‘lpi_config_get’:
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:127:16: error: implicit declaration of function ‘FIELD_GET’ [-Werror=implicit-function-declaration]
127 | pull = FIELD_GET(LPI_GPIO_PULL_MASK, ctl_reg);
| ^~~~~~~~~
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function ‘lpi_config_set’:
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:233:23: error: implicit declaration of function ‘u32_encode_bits’ [-Werror=implicit-function-declaration]
233 | val = u32_encode_bits(value ? 1 : 0, LPI_GPIO_VALUE_OUT_MASK);
| ^~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

bitfield.h was included via pinctrl-lpass-lpi.h but another change
removed that include to restrict what was being included. Add bitfield.h
back to pinctrl-lpass-lpi.c, as it is needed there.

Fixes: aa9430f8a6de ("pinctrl: qcom: Add missing header(s)")
Signed-off-by: Nathan Chancellor <[email protected]>
---
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
index d5cfa91e2eff..3dc670faa59e 100644
--- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
+++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
@@ -4,6 +4,7 @@
* Copyright (c) 2020 Linaro Ltd.
*/

+#include <linux/bitfield.h>
#include <linux/clk.h>
#include <linux/gpio/driver.h>
#include <linux/module.h>

base-commit: 76f3768132eab2c26c9d67022b452358adc28b2c
--
2.38.1

2022-10-27 20:35:18

by Andy Shevchenko

Subject: Re: [PATCH -next] pinctrl: qcom: Include bitfield.h in pinctrl-lpass-lpi.c

On Thu, Oct 27, 2022 at 12:16:25PM -0700, Nathan Chancellor wrote:
> When building ARCH=arm allmodconfig, the following error occurs:
>
> drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function ‘lpi_gpio_set_mux’:
> drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:102:9: error: implicit declaration of function ‘u32p_replace_bits’ [-Werror=implicit-function-declaration]
> 102 | u32p_replace_bits(&val, i, LPI_GPIO_FUNCTION_MASK);
> | ^~~~~~~~~~~~~~~~~
> drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function ‘lpi_config_get’:
> drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:127:16: error: implicit declaration of function ‘FIELD_GET’ [-Werror=implicit-function-declaration]
> 127 | pull = FIELD_GET(LPI_GPIO_PULL_MASK, ctl_reg);
> | ^~~~~~~~~
> drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function ‘lpi_config_set’:
> drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:233:23: error: implicit declaration of function ‘u32_encode_bits’ [-Werror=implicit-function-declaration]
> 233 | val = u32_encode_bits(value ? 1 : 0, LPI_GPIO_VALUE_OUT_MASK);
> | ^~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> bitfield.h was included via pinctrl-lpass-lpi.h but another change
> removed that include to restrict what was being included. Add bitfield.h
> back to pinctrl-lpass-lpi.c, as it is needed there.

Thanks, https://lore.kernel.org/linux-gpio/[email protected]/

--
With Best Regards,
Andy Shevchenko

2022-11-01 15:36:47

by Andy Shevchenko

Subject: Re: [PATCH -next] pinctrl: qcom: Include bitfield.h in pinctrl-lpass-lpi.c

On Thu, Oct 27, 2022 at 10:30:26PM +0300, Andy Shevchenko wrote:
> On Thu, Oct 27, 2022 at 12:16:25PM -0700, Nathan Chancellor wrote:
> > When building ARCH=arm allmodconfig, the following error occurs:

I have pushed my version to the tree, so it will appear in the next Linux Next.

--
With Best Regards,
Andy Shevchenko