2022-11-04 01:26:32

by Yang Li

[permalink] [raw]
Subject: [PATCH -next] net: ethernet: Simplify bool conversion

./drivers/net/ethernet/renesas/rcar_gen4_ptp.c:32:40-45: WARNING: conversion to bool not needed here

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2729
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/net/ethernet/renesas/rcar_gen4_ptp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c
index c007e33c47e1..37f7359678e5 100644
--- a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c
+++ b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c
@@ -29,7 +29,7 @@ static const struct rcar_gen4_ptp_reg_offset s4_offs = {
static int rcar_gen4_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm)
{
struct rcar_gen4_ptp_private *ptp_priv = ptp_to_priv(ptp);
- bool neg_adj = scaled_ppm < 0 ? true : false;
+ bool neg_adj = scaled_ppm < 0;
s64 addend = ptp_priv->default_addend;
s64 diff;

--
2.20.1.7.g153144c



2022-11-04 02:22:08

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH -next] net: ethernet: Simplify bool conversion

On Fri, Nov 04, 2022 at 09:06:35AM +0800, Yang Li wrote:
> ./drivers/net/ethernet/renesas/rcar_gen4_ptp.c:32:40-45: WARNING: conversion to bool not needed here
>

Similar requested description change as [1].

[1]: https://lore.kernel.org/lkml/[email protected]/

--
An old man doll... just what I always wanted! - Clara


Attachments:
(No filename) (341.00 B)
signature.asc (235.00 B)
Download all attachments