2022-11-05 11:26:59

by Christophe JAILLET

Subject: [PATCH] ipmi/watchdog: Include <linux/kstrtox.h> when appropriate

The kstrto<something>() functions have been moved from kernel.h to
kstrtox.h.

So, in order to eventually remove <linux/kernel.h> from <linux/watchdog.h>,
include the latter directly in the appropriate files.

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/char/ipmi/ipmi_watchdog.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
index 5b4e677929ca..47365150e431 100644
--- a/drivers/char/ipmi/ipmi_watchdog.c
+++ b/drivers/char/ipmi/ipmi_watchdog.c
@@ -23,6 +23,7 @@
#include <linux/init.h>
#include <linux/completion.h>
#include <linux/kdebug.h>
+#include <linux/kstrtox.h>
#include <linux/rwsem.h>
#include <linux/errno.h>
#include <linux/uaccess.h>
--
2.34.1

2022-11-06 01:44:47

by Corey Minyard

Subject: Re: [PATCH] ipmi/watchdog: Include <linux/kstrtox.h> when appropriate

On Sat, Nov 05, 2022 at 12:16:54PM +0100, Christophe JAILLET wrote:
> The kstrto<something>() functions have been moved from kernel.h to
> kstrtox.h.
>
> So, in order to eventually remove <linux/kernel.h> from <linux/watchdog.h>,
> include the latter directly in the appropriate files.

This is in my queue. Thanks.

-corey

>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> drivers/char/ipmi/ipmi_watchdog.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
> index 5b4e677929ca..47365150e431 100644
> --- a/drivers/char/ipmi/ipmi_watchdog.c
> +++ b/drivers/char/ipmi/ipmi_watchdog.c
> @@ -23,6 +23,7 @@
> #include <linux/init.h>
> #include <linux/completion.h>
> #include <linux/kdebug.h>
> +#include <linux/kstrtox.h>
> #include <linux/rwsem.h>
> #include <linux/errno.h>
> #include <linux/uaccess.h>
> --
> 2.34.1
>