2022-11-06 21:44:54

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: Fixes tag needs some work in the phy-next tree

---

Hi all,

In commits

5b679072af07 ("phy: usb: Fix clock imbalance for suspend/resume")
219ec4e8f7b2 ("phy: usb: Use slow clock for wake enabled suspend")

Fixes tag

Fixes: ae532b2b7aa5 ("usb: Add "wake on" functionality for newer Synopsis XHCI controllers")

has these problem(s):

- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2022-11-07 01:15:32

by Justin Chen

[permalink] [raw]

Subject: Re: linux-next: Fixes tag needs some work in the phy-next tree

---

On Sun, Nov 6, 2022 at 1:12 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> In commits
>
> 5b679072af07 ("phy: usb: Fix clock imbalance for suspend/resume")
> 219ec4e8f7b2 ("phy: usb: Use slow clock for wake enabled suspend")
>
> Fixes tag
>
> Fixes: ae532b2b7aa5 ("usb: Add "wake on" functionality for newer Synopsis XHCI controllers")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
Apologies, I missed the "phy:" in the beginning. Should be this.
Fixes: ae532b2b7aa5 ("phy: usb: Add "wake on" functionality for newer
Synopsis XHCI controllers")

How should I fix this? Can this be fixed in place?

Thanks,
Justin
> --
> Cheers,
> Stephen Rothwell

2022-11-07 05:31:08

by Vinod Koul

[permalink] [raw]

Subject: Re: linux-next: Fixes tag needs some work in the phy-next tree

---

On 06-11-22, 17:10, Justin Chen wrote:
> On Sun, Nov 6, 2022 at 1:12 PM Stephen Rothwell <[email protected]> wrote:
> >
> > Hi all,
> >
> > In commits
> >
> > 5b679072af07 ("phy: usb: Fix clock imbalance for suspend/resume")
> > 219ec4e8f7b2 ("phy: usb: Use slow clock for wake enabled suspend")
> >
> > Fixes tag
> >
> > Fixes: ae532b2b7aa5 ("usb: Add "wake on" functionality for newer Synopsis XHCI controllers")
> >
> > has these problem(s):
> >
> > - Subject does not match target commit subject

Fixed now

> > Just use
> > git log -1 --format='Fixes: %h ("%s")'
> >
> Apologies, I missed the "phy:" in the beginning. Should be this.
> Fixes: ae532b2b7aa5 ("phy: usb: Add "wake on" functionality for newer
> Synopsis XHCI controllers")

Use the script above to generate this and not manually
>
> How should I fix this? Can this be fixed in place?

I have fixed it up

--
~Vinod