2022-11-08 05:02:40

by Ninad Malwade

[permalink] [raw]
Subject: [PATCH] ina3221: Fix shunt sum critical calculation

The shunt sum critical limit register value should be left shifted
by one bit as its LSB-0 is a reserved bit.

Signed-off-by: Ninad Malwade <[email protected]>
---
drivers/hwmon/ina3221.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c
index 2a57f4b60c29..e06186986444 100644
--- a/drivers/hwmon/ina3221.c
+++ b/drivers/hwmon/ina3221.c
@@ -228,7 +228,7 @@ static int ina3221_read_value(struct ina3221_data *ina, unsigned int reg,
* Shunt Voltage Sum register has 14-bit value with 1-bit shift
* Other Shunt Voltage registers have 12 bits with 3-bit shift
*/
- if (reg == INA3221_SHUNT_SUM)
+ if (reg == INA3221_SHUNT_SUM || reg == INA3221_CRIT_SUM)
*val = sign_extend32(regval >> 1, 14);
else
*val = sign_extend32(regval >> 3, 12);
@@ -465,7 +465,7 @@ static int ina3221_write_curr(struct device *dev, u32 attr,
* SHUNT_SUM: (1 / 40uV) << 1 = 1 / 20uV
* SHUNT[1-3]: (1 / 40uV) << 3 = 1 / 5uV
*/
- if (reg == INA3221_SHUNT_SUM)
+ if (reg == INA3221_SHUNT_SUM || reg == INA3221_CRIT_SUM)
regval = DIV_ROUND_CLOSEST(voltage_uv, 20) & 0xfffe;
else
regval = DIV_ROUND_CLOSEST(voltage_uv, 5) & 0xfff8;
--
2.17.1



2022-11-08 13:37:38

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] ina3221: Fix shunt sum critical calculation

On Tue, Nov 08, 2022 at 12:45:08PM +0800, Ninad Malwade wrote:
> The shunt sum critical limit register value should be left shifted
> by one bit as its LSB-0 is a reserved bit.
>
> Signed-off-by: Ninad Malwade <[email protected]>
> ---
> drivers/hwmon/ina3221.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Looks correct:

Reviewed-by: Thierry Reding <[email protected]>

Attachments:
(No filename) (404.00 B)
 signature.asc (849.00 B)
 Download all attachments

2022-11-11 16:43:50

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH] ina3221: Fix shunt sum critical calculation

On Tue, Nov 08, 2022 at 12:45:08PM +0800, Ninad Malwade wrote:
> The shunt sum critical limit register value should be left shifted
> by one bit as its LSB-0 is a reserved bit.
>
> Signed-off-by: Ninad Malwade <[email protected]>
> Reviewed-by: Thierry Reding <[email protected]>

Applied.

Thanks,
Guenter