2022-11-09 10:04:56

by Manivannan Sadhasivam

Subject: [PATCH] PCI: qcom: Fix error message for reset_control_assert()

Fix the error message to mention "assert" instead of "deassert".

Signed-off-by: Manivannan Sadhasivam <[email protected]>
---
drivers/pci/controller/dwc/pcie-qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index f711acacaeaf..cf27345f6575 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -1236,7 +1236,7 @@ static int qcom_pcie_init_2_7_0(struct qcom_pcie *pcie)

ret = reset_control_assert(res->pci_reset);
if (ret < 0) {
- dev_err(dev, "cannot deassert pci reset\n");
+ dev_err(dev, "cannot assert pci reset\n");
goto err_disable_clocks;
}

--
2.25.1

2022-11-09 11:25:17

by Vinod Koul

Subject: Re: [PATCH] PCI: qcom: Fix error message for reset_control_assert()

On 09-11-22, 15:10, Manivannan Sadhasivam wrote:
> Fix the error message to mention "assert" instead of "deassert".

Reviewed-by: Vinod Koul <[email protected]>

>
> Signed-off-by: Manivannan Sadhasivam <[email protected]>
> ---
> drivers/pci/controller/dwc/pcie-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
> index f711acacaeaf..cf27345f6575 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> @@ -1236,7 +1236,7 @@ static int qcom_pcie_init_2_7_0(struct qcom_pcie *pcie)
>
> ret = reset_control_assert(res->pci_reset);
> if (ret < 0) {
> - dev_err(dev, "cannot deassert pci reset\n");
> + dev_err(dev, "cannot assert pci reset\n");
> goto err_disable_clocks;
> }
>
> --
> 2.25.1

--
~Vinod

2022-11-10 15:15:00

by Lorenzo Pieralisi

Subject: Re: [PATCH] PCI: qcom: Fix error message for reset_control_assert()

On Wed, 9 Nov 2022 15:10:39 +0530, Manivannan Sadhasivam wrote:
> Fix the error message to mention "assert" instead of "deassert".
>
>

Applied to pci/dwc, thanks!

[1/1] PCI: qcom: Fix error message for reset_control_assert()
https://git.kernel.org/lpieralisi/pci/c/fba31beab357

Thanks,
Lorenzo