2022-11-16 08:52:47

by Matti Vaittinen

[permalink] [raw]

Subject: [PATCH RESEND] fixp-arith: do not require users to include bug.h

---

The fixp_sin32_rad()() contains a call to BUG_ON(). If users of
fixp-arith.h have not included the bug.h prior including the fixp-arith.h
the compiler will not find the BUG_ON. Thus every user of fixp-arith.h
must also include bug.h (or roll own variant of BUG_ON()).

Include bug.h from fixp-arith.h so every user of fixp-arith.h does not
need to include the bug.h prior inclusion of fixp-arith.h

Fixes: 559addc25b00 ("[media] fixp-arith: replace sin/cos table by a better precision one")
Signed-off-by: Matti Vaittinen <[email protected]>
---

Another forgotten patch I encountered while cleaning up my local git.
Seems like this has fell through the cracks.

include/linux/fixp-arith.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/linux/fixp-arith.h b/include/linux/fixp-arith.h
index 281cb4f83dbe..e485fb0c1201 100644
--- a/include/linux/fixp-arith.h
+++ b/include/linux/fixp-arith.h
@@ -2,6 +2,7 @@
#ifndef _FIXP_ARITH_H
#define _FIXP_ARITH_H

+#include <linux/bug.h>
#include <linux/math64.h>

/*

base-commit: 094226ad94f471a9f19e8f8e7140a09c2625abaa
--
2.38.1


--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =]

---

Attachments:

(No filename) (1.45 kB)
signature.asc (499.00 B)
Download all attachments

2022-11-17 00:17:52

by Dmitry Torokhov

[permalink] [raw]

Subject: Re: [PATCH RESEND] fixp-arith: do not require users to include bug.h

---

On Wed, Nov 16, 2022 at 10:33:25AM +0200, Matti Vaittinen wrote:
> The fixp_sin32_rad()() contains a call to BUG_ON(). If users of
> fixp-arith.h have not included the bug.h prior including the fixp-arith.h
> the compiler will not find the BUG_ON. Thus every user of fixp-arith.h
> must also include bug.h (or roll own variant of BUG_ON()).
>
> Include bug.h from fixp-arith.h so every user of fixp-arith.h does not
> need to include the bug.h prior inclusion of fixp-arith.h
>
> Fixes: 559addc25b00 ("[media] fixp-arith: replace sin/cos table by a better precision one")
> Signed-off-by: Matti Vaittinen <[email protected]>

Applied, thank you.

--
Dmitry