2022-11-19 01:45:05

by Nhat Pham

Subject: [PATCH v6 5/6] zsmalloc: Add zpool_ops field to zs_pool to store evict handlers

This adds a new field to zs_pool to store evict handlers for writeback,
analogous to the zbud allocator.

Signed-off-by: Nhat Pham <[email protected]>
Acked-by: Minchan Kim <[email protected]>
---
mm/zsmalloc.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 7dd464b5a6a5..9920f3584511 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -242,6 +242,8 @@ struct zs_pool {
#ifdef CONFIG_ZPOOL
/* List tracking the zspages in LRU order by most recently added object */
struct list_head lru;
+ struct zpool *zpool;
+ const struct zpool_ops *zpool_ops;
#endif

#ifdef CONFIG_ZSMALLOC_STAT
@@ -382,7 +384,14 @@ static void *zs_zpool_create(const char *name, gfp_t gfp,
* different contexts and its caller must provide a valid
* gfp mask.
*/
- return zs_create_pool(name);
+ struct zs_pool *pool = zs_create_pool(name);
+
+ if (pool) {
+ pool->zpool = zpool;
+ pool->zpool_ops = zpool_ops;
+ }
+
+ return pool;
}

static void zs_zpool_destroy(void *pool)
--
2.30.2

2022-11-19 17:15:40

by Johannes Weiner

Subject: Re: [PATCH v6 5/6] zsmalloc: Add zpool_ops field to zs_pool to store evict handlers

On Fri, Nov 18, 2022 at 04:15:35PM -0800, Nhat Pham wrote:
> This adds a new field to zs_pool to store evict handlers for writeback,
> analogous to the zbud allocator.
>
> Signed-off-by: Nhat Pham <[email protected]>
> Acked-by: Minchan Kim <[email protected]>

Acked-by: Johannes Weiner <[email protected]>

Nice, much simpler. This should make Sergey happy too :)

2022-11-22 01:54:42

by Sergey Senozhatsky

Subject: Re: [PATCH v6 5/6] zsmalloc: Add zpool_ops field to zs_pool to store evict handlers

On (22/11/19 11:39), Johannes Weiner wrote:
> On Fri, Nov 18, 2022 at 04:15:35PM -0800, Nhat Pham wrote:
> > This adds a new field to zs_pool to store evict handlers for writeback,
> > analogous to the zbud allocator.
> >
> > Signed-off-by: Nhat Pham <[email protected]>
> > Acked-by: Minchan Kim <[email protected]>
>
> Acked-by: Johannes Weiner <[email protected]>
>
> Nice, much simpler. This should make Sergey happy too :)

Yup looks good :)