2022-11-18 23:23:09

by Uwe Kleine-König

Subject: [PATCH 020/606] drm/bridge: it6505: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/gpu/drm/bridge/ite-it6505.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index 21a9b8422bda..fea2b4279c31 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -3265,8 +3265,7 @@ static void it6505_shutdown(struct i2c_client *client)
it6505_lane_off(it6505);
}

-static int it6505_i2c_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int it6505_i2c_probe(struct i2c_client *client)
{
struct it6505 *it6505;
struct device *dev = &client->dev;
@@ -3387,7 +3386,7 @@ static struct i2c_driver it6505_i2c_driver = {
.of_match_table = it6505_of_match,
.pm = &it6505_bridge_pm_ops,
},
- .probe = it6505_i2c_probe,
+ .probe_new = it6505_i2c_probe,
.remove = it6505_i2c_remove,
.shutdown = it6505_shutdown,
.id_table = it6505_id,
--
2.38.1

2022-11-19 17:31:40

by Laurent Pinchart

Subject: Re: [PATCH 020/606] drm/bridge: it6505: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:35:54PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/gpu/drm/bridge/ite-it6505.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
> index 21a9b8422bda..fea2b4279c31 100644
> --- a/drivers/gpu/drm/bridge/ite-it6505.c
> +++ b/drivers/gpu/drm/bridge/ite-it6505.c
> @@ -3265,8 +3265,7 @@ static void it6505_shutdown(struct i2c_client *client)
> it6505_lane_off(it6505);
> }
>
> -static int it6505_i2c_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int it6505_i2c_probe(struct i2c_client *client)
> {
> struct it6505 *it6505;
> struct device *dev = &client->dev;
> @@ -3387,7 +3386,7 @@ static struct i2c_driver it6505_i2c_driver = {
> .of_match_table = it6505_of_match,
> .pm = &it6505_bridge_pm_ops,
> },
> - .probe = it6505_i2c_probe,
> + .probe_new = it6505_i2c_probe,
> .remove = it6505_i2c_remove,
> .shutdown = it6505_shutdown,
> .id_table = it6505_id,

--
Regards,

Laurent Pinchart