2022-11-18 22:50:50

by Uwe Kleine-König

Subject: [PATCH 027/606] drm/bridge: nxp-ptn3460: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/gpu/drm/bridge/nxp-ptn3460.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c
index 0851101a8c72..cd292a2f894c 100644
--- a/drivers/gpu/drm/bridge/nxp-ptn3460.c
+++ b/drivers/gpu/drm/bridge/nxp-ptn3460.c
@@ -257,8 +257,7 @@ static const struct drm_bridge_funcs ptn3460_bridge_funcs = {
.get_edid = ptn3460_get_edid,
};

-static int ptn3460_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int ptn3460_probe(struct i2c_client *client)
{
struct device *dev = &client->dev;
struct ptn3460_bridge *ptn_bridge;
@@ -336,7 +335,7 @@ MODULE_DEVICE_TABLE(of, ptn3460_match);

static struct i2c_driver ptn3460_driver = {
.id_table = ptn3460_i2c_table,
- .probe = ptn3460_probe,
+ .probe_new = ptn3460_probe,
.remove = ptn3460_remove,
.driver = {
.name = "nxp,ptn3460",
--
2.38.1

2022-11-19 17:47:19

by Laurent Pinchart

Subject: Re: [PATCH 027/606] drm/bridge: nxp-ptn3460: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:36:01PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/gpu/drm/bridge/nxp-ptn3460.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c
> index 0851101a8c72..cd292a2f894c 100644
> --- a/drivers/gpu/drm/bridge/nxp-ptn3460.c
> +++ b/drivers/gpu/drm/bridge/nxp-ptn3460.c
> @@ -257,8 +257,7 @@ static const struct drm_bridge_funcs ptn3460_bridge_funcs = {
> .get_edid = ptn3460_get_edid,
> };
>
> -static int ptn3460_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int ptn3460_probe(struct i2c_client *client)
> {
> struct device *dev = &client->dev;
> struct ptn3460_bridge *ptn_bridge;
> @@ -336,7 +335,7 @@ MODULE_DEVICE_TABLE(of, ptn3460_match);
>
> static struct i2c_driver ptn3460_driver = {
> .id_table = ptn3460_i2c_table,
> - .probe = ptn3460_probe,
> + .probe_new = ptn3460_probe,
> .remove = ptn3460_remove,
> .driver = {
> .name = "nxp,ptn3460",
> --
> 2.38.1
>

--
Regards,

Laurent Pinchart