2022-11-18 23:20:38

by Uwe Kleine-König

Subject: [PATCH 032/606] drm/bridge: tc358767: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/gpu/drm/bridge/tc358767.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
index 2a58eb271f70..a4725efe812d 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -2029,7 +2029,7 @@ static void tc_clk_disable(void *data)
clk_disable_unprepare(refclk);
}

-static int tc_probe(struct i2c_client *client, const struct i2c_device_id *id)
+static int tc_probe(struct i2c_client *client)
{
struct device *dev = &client->dev;
struct tc_data *tc;
@@ -2209,7 +2209,7 @@ static struct i2c_driver tc358767_driver = {
.of_match_table = tc358767_of_ids,
},
.id_table = tc358767_i2c_ids,
- .probe = tc_probe,
+ .probe_new = tc_probe,
.remove = tc_remove,
};
module_i2c_driver(tc358767_driver);
--
2.38.1

2022-11-19 17:52:46

by Laurent Pinchart

Subject: Re: [PATCH 032/606] drm/bridge: tc358767: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:36:06PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/gpu/drm/bridge/tc358767.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
> index 2a58eb271f70..a4725efe812d 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -2029,7 +2029,7 @@ static void tc_clk_disable(void *data)
> clk_disable_unprepare(refclk);
> }
>
> -static int tc_probe(struct i2c_client *client, const struct i2c_device_id *id)
> +static int tc_probe(struct i2c_client *client)
> {
> struct device *dev = &client->dev;
> struct tc_data *tc;
> @@ -2209,7 +2209,7 @@ static struct i2c_driver tc358767_driver = {
> .of_match_table = tc358767_of_ids,
> },
> .id_table = tc358767_i2c_ids,
> - .probe = tc_probe,
> + .probe_new = tc_probe,
> .remove = tc_remove,
> };
> module_i2c_driver(tc358767_driver);
> --
> 2.38.1
>

--
Regards,

Laurent Pinchart