2022-11-18 23:17:50

by Uwe Kleine-König

Subject: [PATCH 037/606] drm/bridge: tfp410: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/gpu/drm/bridge/ti-tfp410.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
index b9635abbad16..6db69df0e18b 100644
--- a/drivers/gpu/drm/bridge/ti-tfp410.c
+++ b/drivers/gpu/drm/bridge/ti-tfp410.c
@@ -379,8 +379,7 @@ static struct platform_driver tfp410_platform_driver = {

#if IS_ENABLED(CONFIG_I2C)
/* There is currently no i2c functionality. */
-static int tfp410_i2c_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int tfp410_i2c_probe(struct i2c_client *client)
{
int reg;

@@ -411,7 +410,7 @@ static struct i2c_driver tfp410_i2c_driver = {
.of_match_table = of_match_ptr(tfp410_match),
},
.id_table = tfp410_i2c_ids,
- .probe = tfp410_i2c_probe,
+ .probe_new = tfp410_i2c_probe,
.remove = tfp410_i2c_remove,
};
#endif /* IS_ENABLED(CONFIG_I2C) */
--
2.38.1

2022-11-19 17:42:34

by Laurent Pinchart

Subject: Re: [PATCH 037/606] drm/bridge: tfp410: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:36:11PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/gpu/drm/bridge/ti-tfp410.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
> index b9635abbad16..6db69df0e18b 100644
> --- a/drivers/gpu/drm/bridge/ti-tfp410.c
> +++ b/drivers/gpu/drm/bridge/ti-tfp410.c
> @@ -379,8 +379,7 @@ static struct platform_driver tfp410_platform_driver = {
>
> #if IS_ENABLED(CONFIG_I2C)
> /* There is currently no i2c functionality. */
> -static int tfp410_i2c_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int tfp410_i2c_probe(struct i2c_client *client)
> {
> int reg;
>
> @@ -411,7 +410,7 @@ static struct i2c_driver tfp410_i2c_driver = {
> .of_match_table = of_match_ptr(tfp410_match),
> },
> .id_table = tfp410_i2c_ids,
> - .probe = tfp410_i2c_probe,
> + .probe_new = tfp410_i2c_probe,
> .remove = tfp410_i2c_remove,
> };
> #endif /* IS_ENABLED(CONFIG_I2C) */
> --
> 2.38.1
>

--
Regards,

Laurent Pinchart