2022-11-18 23:21:41

by Uwe Kleine-König

[permalink] [raw]
Subject: [PATCH 015/606] drm/bridge/analogix/anx6345: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
index 660a54857929..339e0f05b260 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
@@ -692,8 +692,7 @@ static bool anx6345_get_chip_id(struct anx6345 *anx6345)
return false;
}

-static int anx6345_i2c_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int anx6345_i2c_probe(struct i2c_client *client)
{
struct anx6345 *anx6345;
struct device *dev;
@@ -817,7 +816,7 @@ static struct i2c_driver anx6345_driver = {
.name = "anx6345",
.of_match_table = of_match_ptr(anx6345_match_table),
},
- .probe = anx6345_i2c_probe,
+ .probe_new = anx6345_i2c_probe,
.remove = anx6345_i2c_remove,
.id_table = anx6345_id,
};
--
2.38.1



2022-11-19 18:57:09

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH 015/606] drm/bridge/analogix/anx6345: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:35:49PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> index 660a54857929..339e0f05b260 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> @@ -692,8 +692,7 @@ static bool anx6345_get_chip_id(struct anx6345 *anx6345)
> return false;
> }
>
> -static int anx6345_i2c_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int anx6345_i2c_probe(struct i2c_client *client)
> {
> struct anx6345 *anx6345;
> struct device *dev;
> @@ -817,7 +816,7 @@ static struct i2c_driver anx6345_driver = {
> .name = "anx6345",
> .of_match_table = of_match_ptr(anx6345_match_table),
> },
> - .probe = anx6345_i2c_probe,
> + .probe_new = anx6345_i2c_probe,
> .remove = anx6345_i2c_remove,
> .id_table = anx6345_id,
> };
> --
> 2.38.1
>

--
Regards,

Laurent Pinchart