2022-11-19 00:47:44

by Uwe Kleine-König

Subject: [PATCH 035/606] drm/bridge: ti-sn65dsi83: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/gpu/drm/bridge/ti-sn65dsi83.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
index 7ba9467fff12..aab7412b09bd 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
@@ -653,9 +653,9 @@ static int sn65dsi83_host_attach(struct sn65dsi83 *ctx)
return 0;
}

-static int sn65dsi83_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int sn65dsi83_probe(struct i2c_client *client)
{
+ const struct i2c_device_id *id = i2c_client_get_device_id(client);
struct device *dev = &client->dev;
enum sn65dsi83_model model;
struct sn65dsi83 *ctx;
@@ -730,7 +730,7 @@ static const struct of_device_id sn65dsi83_match_table[] = {
MODULE_DEVICE_TABLE(of, sn65dsi83_match_table);

static struct i2c_driver sn65dsi83_driver = {
- .probe = sn65dsi83_probe,
+ .probe_new = sn65dsi83_probe,
.remove = sn65dsi83_remove,
.id_table = sn65dsi83_id,
.driver = {
--
2.38.1

2022-11-19 18:21:00

by Laurent Pinchart

Subject: Re: [PATCH 035/606] drm/bridge: ti-sn65dsi83: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:36:09PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <[email protected]>
>
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/gpu/drm/bridge/ti-sn65dsi83.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> index 7ba9467fff12..aab7412b09bd 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> @@ -653,9 +653,9 @@ static int sn65dsi83_host_attach(struct sn65dsi83 *ctx)
> return 0;
> }
>
> -static int sn65dsi83_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int sn65dsi83_probe(struct i2c_client *client)
> {
> + const struct i2c_device_id *id = i2c_client_get_device_id(client);
> struct device *dev = &client->dev;
> enum sn65dsi83_model model;
> struct sn65dsi83 *ctx;
> @@ -730,7 +730,7 @@ static const struct of_device_id sn65dsi83_match_table[] = {
> MODULE_DEVICE_TABLE(of, sn65dsi83_match_table);
>
> static struct i2c_driver sn65dsi83_driver = {
> - .probe = sn65dsi83_probe,
> + .probe_new = sn65dsi83_probe,
> .remove = sn65dsi83_remove,
> .id_table = sn65dsi83_id,
> .driver = {
> --
> 2.38.1
>

--
Regards,

Laurent Pinchart