2022-11-19 00:41:14

by Uwe Kleine-König

Subject: [PATCH 584/606] usb: typec: ucsi: stm32g0: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/usb/typec/ucsi/ucsi_stm32g0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/typec/ucsi/ucsi_stm32g0.c b/drivers/usb/typec/ucsi/ucsi_stm32g0.c
index 7b92f0c8de70..93fead0096b7 100644
--- a/drivers/usb/typec/ucsi/ucsi_stm32g0.c
+++ b/drivers/usb/typec/ucsi/ucsi_stm32g0.c
@@ -626,7 +626,7 @@ static int ucsi_stm32g0_probe_bootloader(struct ucsi *ucsi)
return 0;
}

-static int ucsi_stm32g0_probe(struct i2c_client *client, const struct i2c_device_id *id)
+static int ucsi_stm32g0_probe(struct i2c_client *client)
{
struct device *dev = &client->dev;
struct ucsi_stm32g0 *g0;
@@ -763,7 +763,7 @@ static struct i2c_driver ucsi_stm32g0_i2c_driver = {
.of_match_table = of_match_ptr(ucsi_stm32g0_typec_of_match),
.pm = pm_sleep_ptr(&ucsi_stm32g0_pm_ops),
},
- .probe = ucsi_stm32g0_probe,
+ .probe_new = ucsi_stm32g0_probe,
.remove = ucsi_stm32g0_remove,
.id_table = ucsi_stm32g0_typec_i2c_devid
};
--
2.38.1

2022-11-21 09:21:26

by Heikki Krogerus

Subject: Re: [PATCH 584/606] usb: typec: ucsi: stm32g0: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:45:18PM +0100, Uwe Kleine-K?nig wrote:
> From: Uwe Kleine-K?nig <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-K?nig <[email protected]>

Reviewed-by: Heikki Krogerus <[email protected]>

> ---
> drivers/usb/typec/ucsi/ucsi_stm32g0.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi_stm32g0.c b/drivers/usb/typec/ucsi/ucsi_stm32g0.c
> index 7b92f0c8de70..93fead0096b7 100644
> --- a/drivers/usb/typec/ucsi/ucsi_stm32g0.c
> +++ b/drivers/usb/typec/ucsi/ucsi_stm32g0.c
> @@ -626,7 +626,7 @@ static int ucsi_stm32g0_probe_bootloader(struct ucsi *ucsi)
> return 0;
> }
>
> -static int ucsi_stm32g0_probe(struct i2c_client *client, const struct i2c_device_id *id)
> +static int ucsi_stm32g0_probe(struct i2c_client *client)
> {
> struct device *dev = &client->dev;
> struct ucsi_stm32g0 *g0;
> @@ -763,7 +763,7 @@ static struct i2c_driver ucsi_stm32g0_i2c_driver = {
> .of_match_table = of_match_ptr(ucsi_stm32g0_typec_of_match),
> .pm = pm_sleep_ptr(&ucsi_stm32g0_pm_ops),
> },
> - .probe = ucsi_stm32g0_probe,
> + .probe_new = ucsi_stm32g0_probe,
> .remove = ucsi_stm32g0_remove,
> .id_table = ucsi_stm32g0_typec_i2c_devid
> };

thanks,

--
heikki