2022-11-18 23:51:51

by Uwe Kleine-König

[permalink] [raw]
Subject: [PATCH 593/606] backlight: tosa: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/video/backlight/tosa_bl.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/video/backlight/tosa_bl.c b/drivers/video/backlight/tosa_bl.c
index f55b3d616a87..77b71f6c19b5 100644
--- a/drivers/video/backlight/tosa_bl.c
+++ b/drivers/video/backlight/tosa_bl.c
@@ -75,8 +75,7 @@ static const struct backlight_ops bl_ops = {
.update_status = tosa_bl_update_status,
};

-static int tosa_bl_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int tosa_bl_probe(struct i2c_client *client)
{
struct backlight_properties props;
struct tosa_bl_data *data;
@@ -160,7 +159,7 @@ static struct i2c_driver tosa_bl_driver = {
.name = "tosa-bl",
.pm = &tosa_bl_pm_ops,
},
- .probe = tosa_bl_probe,
+ .probe_new = tosa_bl_probe,
.remove = tosa_bl_remove,
.id_table = tosa_bl_id,
};
--
2.38.1



2022-11-21 11:24:00

by Daniel Thompson

[permalink] [raw]
Subject: Re: [PATCH 593/606] backlight: tosa: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:45:27PM +0100, Uwe Kleine-K?nig wrote:
> From: Uwe Kleine-K?nig <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-K?nig <[email protected]>

Reviewed-by: Daniel Thompson <[email protected]>


Daniel.