2022-11-23 00:05:32

by Michael Forney

Subject: [PATCH] iommu/amd: Fix typo in macro parameter name

IVRS_GET_SBDF_ID is only called with fn as the fourth parameter,
so this had no effect, but fixing the name will avoid bugs if that
ever changes.

Signed-off-by: Michael Forney <[email protected]>
---
drivers/iommu/amd/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
index 1a2d425bf568..099ca3ed7d73 100644
--- a/drivers/iommu/amd/init.c
+++ b/drivers/iommu/amd/init.c
@@ -85,7 +85,7 @@

#define LOOP_TIMEOUT 2000000

-#define IVRS_GET_SBDF_ID(seg, bus, dev, fd) (((seg & 0xffff) << 16) | ((bus & 0xff) << 8) \
+#define IVRS_GET_SBDF_ID(seg, bus, dev, fn) (((seg & 0xffff) << 16) | ((bus & 0xff) << 8) \
| ((dev & 0x1f) << 3) | (fn & 0x7))

/*
--
2.37.3

2022-11-24 04:58:23

by Vasant Hegde

Subject: Re: [PATCH] iommu/amd: Fix typo in macro parameter name

HI Michael,

On 11/23/2022 3:48 AM, Michael Forney wrote:
> IVRS_GET_SBDF_ID is only called with fn as the fourth parameter,
> so this had no effect, but fixing the name will avoid bugs if that
> ever changes.>
> Signed-off-by: Michael Forney <[email protected]>

Thanks for finding and fixing this issue.

Reviewed-by: Vasant Hegde <[email protected]>

-Vasant

> ---
> drivers/iommu/amd/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
> index 1a2d425bf568..099ca3ed7d73 100644
> --- a/drivers/iommu/amd/init.c
> +++ b/drivers/iommu/amd/init.c
> @@ -85,7 +85,7 @@
>
> #define LOOP_TIMEOUT 2000000
>
> -#define IVRS_GET_SBDF_ID(seg, bus, dev, fd) (((seg & 0xffff) << 16) | ((bus & 0xff) << 8) \
> +#define IVRS_GET_SBDF_ID(seg, bus, dev, fn) (((seg & 0xffff) << 16) | ((bus & 0xff) << 8) \
> | ((dev & 0x1f) << 3) | (fn & 0x7))
>
> /*

2022-12-05 11:11:38

by Joerg Roedel

Subject: Re: [PATCH] iommu/amd: Fix typo in macro parameter name

On Tue, Nov 22, 2022 at 02:18:25PM -0800, Michael Forney wrote:
> IVRS_GET_SBDF_ID is only called with fn as the fourth parameter,
> so this had no effect, but fixing the name will avoid bugs if that
> ever changes.
>
> Signed-off-by: Michael Forney <[email protected]>
> ---
> drivers/iommu/amd/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.