2022-12-05 03:58:59

by ye.xingchen

Subject: [PATCH net-next] s390/qeth: use sysfs_emit() to instead of scnprintf()

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <[email protected]>
---
drivers/s390/net/qeth_l3_sys.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/s390/net/qeth_l3_sys.c b/drivers/s390/net/qeth_l3_sys.c
index 1082380b21f8..65eea667e469 100644
--- a/drivers/s390/net/qeth_l3_sys.c
+++ b/drivers/s390/net/qeth_l3_sys.c
@@ -395,7 +395,7 @@ static ssize_t qeth_l3_dev_ipato_add_show(char *buf, struct qeth_card *card,
}
mutex_unlock(&card->ip_lock);

- return str_len ? str_len : scnprintf(buf, PAGE_SIZE, "\n");
+ return str_len ? str_len : sysfs_emit(buf, "\n");
}

static ssize_t qeth_l3_dev_ipato_add4_show(struct device *dev,
@@ -614,7 +614,7 @@ static ssize_t qeth_l3_dev_ip_add_show(struct device *dev, char *buf,
}
mutex_unlock(&card->ip_lock);

- return str_len ? str_len : scnprintf(buf, PAGE_SIZE, "\n");
+ return str_len ? str_len : sysfs_emit(buf, "\n");
}

static ssize_t qeth_l3_dev_vipa_add4_show(struct device *dev,
--
2.25.1

2022-12-05 12:07:27

by Alexandra Winter

Subject: Re: [PATCH net-next] s390/qeth: use sysfs_emit() to instead of scnprintf()

On 05.12.22 04:52, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: ye xingchen <[email protected]>
> ---
> drivers/s390/net/qeth_l3_sys.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/s390/net/qeth_l3_sys.c b/drivers/s390/net/qeth_l3_sys.c
> index 1082380b21f8..65eea667e469 100644
> --- a/drivers/s390/net/qeth_l3_sys.c
> +++ b/drivers/s390/net/qeth_l3_sys.c
> @@ -395,7 +395,7 @@ static ssize_t qeth_l3_dev_ipato_add_show(char *buf, struct qeth_card *card,
> }
> mutex_unlock(&card->ip_lock);
>
> - return str_len ? str_len : scnprintf(buf, PAGE_SIZE, "\n");
> + return str_len ? str_len : sysfs_emit(buf, "\n");
> }
>
> static ssize_t qeth_l3_dev_ipato_add4_show(struct device *dev,
> @@ -614,7 +614,7 @@ static ssize_t qeth_l3_dev_ip_add_show(struct device *dev, char *buf,
> }
> mutex_unlock(&card->ip_lock);
>
> - return str_len ? str_len : scnprintf(buf, PAGE_SIZE, "\n");
> + return str_len ? str_len : sysfs_emit(buf, "\n");
> }
>
> static ssize_t qeth_l3_dev_vipa_add4_show(struct device *dev,
There are more instances of scnprintf in s390/net that can be replaced by sysfs_emit.
We are already working on that.

But thanks for improving those two.
Reviewed-by: Alexandra Winter <[email protected]>

2022-12-05 12:08:32

by Alexander Gordeev

Subject: Re: [PATCH net-next] s390/qeth: use sysfs_emit() to instead of scnprintf()

On Mon, Dec 05, 2022 at 12:38:59PM +0100, Alexandra Winter wrote:
>
>
> On 05.12.22 04:52, [email protected] wrote:
> > From: ye xingchen <[email protected]>
> >
> > Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> > should only use sysfs_emit() or sysfs_emit_at() when formatting the
> > value to be returned to user space.
> >
> > Signed-off-by: ye xingchen <[email protected]>
> > ---
> > drivers/s390/net/qeth_l3_sys.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/s390/net/qeth_l3_sys.c b/drivers/s390/net/qeth_l3_sys.c
> > index 1082380b21f8..65eea667e469 100644
> > --- a/drivers/s390/net/qeth_l3_sys.c
> > +++ b/drivers/s390/net/qeth_l3_sys.c
> > @@ -395,7 +395,7 @@ static ssize_t qeth_l3_dev_ipato_add_show(char *buf, struct qeth_card *card,
> > }
> > mutex_unlock(&card->ip_lock);
> >
> > - return str_len ? str_len : scnprintf(buf, PAGE_SIZE, "\n");
> > + return str_len ? str_len : sysfs_emit(buf, "\n");
> > }
> >
> > static ssize_t qeth_l3_dev_ipato_add4_show(struct device *dev,
> > @@ -614,7 +614,7 @@ static ssize_t qeth_l3_dev_ip_add_show(struct device *dev, char *buf,
> > }
> > mutex_unlock(&card->ip_lock);
> >
> > - return str_len ? str_len : scnprintf(buf, PAGE_SIZE, "\n");
> > + return str_len ? str_len : sysfs_emit(buf, "\n");
> > }
> >
> > static ssize_t qeth_l3_dev_vipa_add4_show(struct device *dev,
> There are more instances of scnprintf in s390/net that can be replaced by sysfs_emit.
> We are already working on that.

It seems this particular fix misses scnprintf() to sysfs_emit()
conversion within same very functions just few lines above.

> But thanks for improving those two.
> Reviewed-by: Alexandra Winter <[email protected]>