2022-11-27 16:20:58

by Christophe JAILLET

[permalink] [raw]
Subject: [PATCH] net/mlx5e: Remove unneeded io-mapping.h #include

The mlx5 net files don't use io_mapping functionalities. So there is no
point in including <linux/io-mapping.h>.
Remove it.

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 1 -
drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 -
drivers/net/ethernet/mellanox/mlx5/core/uar.c | 1 -
3 files changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
index 74bd05e5dda2..597907fd63f5 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
@@ -37,7 +37,6 @@
#include <linux/slab.h>
#include <linux/delay.h>
#include <linux/random.h>
-#include <linux/io-mapping.h>
#include <linux/mlx5/driver.h>
#include <linux/mlx5/eq.h>
#include <linux/debugfs.h>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
index 70e8dc305bec..25e87e5d9270 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
@@ -37,7 +37,6 @@
#include <linux/pci.h>
#include <linux/dma-mapping.h>
#include <linux/slab.h>
-#include <linux/io-mapping.h>
#include <linux/interrupt.h>
#include <linux/delay.h>
#include <linux/mlx5/driver.h>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/uar.c b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
index 8455e79bc44a..1513112ecec8 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/uar.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
@@ -31,7 +31,6 @@
*/

#include <linux/kernel.h>
-#include <linux/io-mapping.h>
#include <linux/mlx5/driver.h>
#include "mlx5_core.h"

--
2.34.1


2022-11-28 05:18:30

by Pavan Chebbi

[permalink] [raw]
Subject: Re: [PATCH] net/mlx5e: Remove unneeded io-mapping.h #include

On Sun, Nov 27, 2022 at 9:47 PM Christophe JAILLET
<[email protected]> wrote:
>
> The mlx5 net files don't use io_mapping functionalities. So there is no
> point in including <linux/io-mapping.h>.
> Remove it.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 1 -
> drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 -
> drivers/net/ethernet/mellanox/mlx5/core/uar.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> index 74bd05e5dda2..597907fd63f5 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> @@ -37,7 +37,6 @@
> #include <linux/slab.h>
> #include <linux/delay.h>
> #include <linux/random.h>
> -#include <linux/io-mapping.h>
> #include <linux/mlx5/driver.h>
> #include <linux/mlx5/eq.h>
> #include <linux/debugfs.h>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> index 70e8dc305bec..25e87e5d9270 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> @@ -37,7 +37,6 @@
> #include <linux/pci.h>
> #include <linux/dma-mapping.h>
> #include <linux/slab.h>
> -#include <linux/io-mapping.h>
> #include <linux/interrupt.h>
> #include <linux/delay.h>
> #include <linux/mlx5/driver.h>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/uar.c b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> index 8455e79bc44a..1513112ecec8 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> @@ -31,7 +31,6 @@
> */
>
> #include <linux/kernel.h>
> -#include <linux/io-mapping.h>
> #include <linux/mlx5/driver.h>
> #include "mlx5_core.h"
>
> --
> 2.34.1
>

Reviewed-by: Pavan Chebbi <[email protected]>

Attachments:
smime.p7s (4.11 kB)
S/MIME Cryptographic Signature

2022-11-28 05:25:37

by Pavan Chebbi

[permalink] [raw]
Subject: Re: [PATCH] net/mlx5e: Remove unneeded io-mapping.h #include

Though I think having the target tree specified conventionally in the
subject line [PATCH net] would be more complying with the process.

On Mon, Nov 28, 2022 at 9:57 AM Pavan Chebbi <[email protected]> wrote:
>
> On Sun, Nov 27, 2022 at 9:47 PM Christophe JAILLET
> <[email protected]> wrote:
> >
> > The mlx5 net files don't use io_mapping functionalities. So there is no
> > point in including <linux/io-mapping.h>.
> > Remove it.
> >
> > Signed-off-by: Christophe JAILLET <[email protected]>
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 1 -
> > drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 -
> > drivers/net/ethernet/mellanox/mlx5/core/uar.c | 1 -
> > 3 files changed, 3 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> > index 74bd05e5dda2..597907fd63f5 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> > @@ -37,7 +37,6 @@
> > #include <linux/slab.h>
> > #include <linux/delay.h>
> > #include <linux/random.h>
> > -#include <linux/io-mapping.h>
> > #include <linux/mlx5/driver.h>
> > #include <linux/mlx5/eq.h>
> > #include <linux/debugfs.h>
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > index 70e8dc305bec..25e87e5d9270 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > @@ -37,7 +37,6 @@
> > #include <linux/pci.h>
> > #include <linux/dma-mapping.h>
> > #include <linux/slab.h>
> > -#include <linux/io-mapping.h>
> > #include <linux/interrupt.h>
> > #include <linux/delay.h>
> > #include <linux/mlx5/driver.h>
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/uar.c b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> > index 8455e79bc44a..1513112ecec8 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> > @@ -31,7 +31,6 @@
> > */
> >
> > #include <linux/kernel.h>
> > -#include <linux/io-mapping.h>
> > #include <linux/mlx5/driver.h>
> > #include "mlx5_core.h"
> >
> > --
> > 2.34.1
> >
>
> Reviewed-by: Pavan Chebbi <[email protected]>

Attachments:
smime.p7s (4.11 kB)
S/MIME Cryptographic Signature

2022-11-30 04:36:25

by Saeed Mahameed

[permalink] [raw]
Subject: Re: [PATCH] net/mlx5e: Remove unneeded io-mapping.h #include

On 28 Nov 10:27, Pavan Chebbi wrote:
>Though I think having the target tree specified conventionally in the
>subject line [PATCH net] would be more complying with the process.

For such cleanup patches I think [PATCH net-next] is better.

[...]

>>
>> Reviewed-by: Pavan Chebbi <[email protected]>

Thanks you Pavan & Christophe
applied to net-next-mlx5 will be sent to net-next shortly