2022-11-28 18:16:29

by Sven Peter

Subject: [PATCH] usb: typec: tipd: Set mode of operation for USB Type-C connector

Forward the mode of operation to the typec subsystem such that it can
configure the mux correctly.

Signed-off-by: Sven Peter <[email protected]>
---
drivers/usb/typec/tipd/core.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index 982bd2cad931..46a4d8b128f0 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -14,6 +14,7 @@
#include <linux/regmap.h>
#include <linux/interrupt.h>
#include <linux/usb/typec.h>
+#include <linux/usb/typec_altmode.h>
#include <linux/usb/role.h>

#include "tps6598x.h"
@@ -257,6 +258,7 @@ static int tps6598x_connect(struct tps6598x *tps, u32 status)
typec_set_orientation(tps->port, TYPEC_ORIENTATION_REVERSE);
else
typec_set_orientation(tps->port, TYPEC_ORIENTATION_NORMAL);
+ typec_set_mode(tps->port, TYPEC_STATE_USB);
tps6598x_set_data_role(tps, TPS_STATUS_TO_TYPEC_DATAROLE(status), true);

tps->partner = typec_register_partner(tps->port, &desc);
@@ -280,6 +282,7 @@ static void tps6598x_disconnect(struct tps6598x *tps, u32 status)
typec_set_pwr_role(tps->port, TPS_STATUS_TO_TYPEC_PORTROLE(status));
typec_set_vconn_role(tps->port, TPS_STATUS_TO_TYPEC_VCONN(status));
typec_set_orientation(tps->port, TYPEC_ORIENTATION_NONE);
+ typec_set_mode(tps->port, TYPEC_STATE_SAFE);
tps6598x_set_data_role(tps, TPS_STATUS_TO_TYPEC_DATAROLE(status), false);

power_supply_changed(tps->psy);
--
2.25.1

2022-11-30 16:14:01

by Heikki Krogerus

Subject: Re: [PATCH] usb: typec: tipd: Set mode of operation for USB Type-C connector

On Mon, Nov 28, 2022 at 05:23:04PM +0100, Sven Peter wrote:
> Forward the mode of operation to the typec subsystem such that it can
> configure the mux correctly.
>
> Signed-off-by: Sven Peter <[email protected]>

Looks OK to me.

Reviewed-by: Heikki Krogerus <[email protected]>

> ---
> drivers/usb/typec/tipd/core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index 982bd2cad931..46a4d8b128f0 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -14,6 +14,7 @@
> #include <linux/regmap.h>
> #include <linux/interrupt.h>
> #include <linux/usb/typec.h>
> +#include <linux/usb/typec_altmode.h>
> #include <linux/usb/role.h>
>
> #include "tps6598x.h"
> @@ -257,6 +258,7 @@ static int tps6598x_connect(struct tps6598x *tps, u32 status)
> typec_set_orientation(tps->port, TYPEC_ORIENTATION_REVERSE);
> else
> typec_set_orientation(tps->port, TYPEC_ORIENTATION_NORMAL);
> + typec_set_mode(tps->port, TYPEC_STATE_USB);
> tps6598x_set_data_role(tps, TPS_STATUS_TO_TYPEC_DATAROLE(status), true);
>
> tps->partner = typec_register_partner(tps->port, &desc);
> @@ -280,6 +282,7 @@ static void tps6598x_disconnect(struct tps6598x *tps, u32 status)
> typec_set_pwr_role(tps->port, TPS_STATUS_TO_TYPEC_PORTROLE(status));
> typec_set_vconn_role(tps->port, TPS_STATUS_TO_TYPEC_VCONN(status));
> typec_set_orientation(tps->port, TYPEC_ORIENTATION_NONE);
> + typec_set_mode(tps->port, TYPEC_STATE_SAFE);
> tps6598x_set_data_role(tps, TPS_STATUS_TO_TYPEC_DATAROLE(status), false);
>
> power_supply_changed(tps->psy);

thanks,

--
heikki