2022-11-30 20:32:41

by Mark Hasemeyer

Subject: [PATCH v8 2/3] dt-bindings: mfd: Add compatible string for UART support

Add a compatible string to support the UART implementation of the cros
ec interface.

Signed-off-by: Bhanu Prakash Maiya <[email protected]>
Signed-off-by: Mark Hasemeyer <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
---

Changes in v8:
- Update commit message

Changes in v7:
- No change

Changes in v6:
- No change

Changes in v5:
- No change

Changes in v4:
- Changes in commit message.

Changes in v3:
- Rebased changes on google,cros-ec.yaml

Changes in v2:
- No change

---
.../devicetree/bindings/mfd/google,cros-ec.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
index 04962bb29576e..26787e4574b8d 100644
--- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
+++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
@@ -28,6 +28,9 @@ properties:
- description:
For implementations of the EC is connected through RPMSG.
const: google,cros-ec-rpmsg
+ - description:
+ For implementations of the EC is connected through UART.
+ const: google,cros-ec-uart

controller-data:
description:
@@ -222,4 +225,12 @@ examples:
compatible = "google,cros-ec-rpmsg";
};
};
+
+ # Example for UART
+ - |
+ uart0 {
+ cros-ec {
+ compatible = "google,cros-ec-uart";
+ };
+ };
...
--
2.38.1.584.g0f3c55d4c2-goog

2022-12-01 06:11:15

by Tzung-Bi Shih

Subject: Re: [PATCH v8 2/3] dt-bindings: mfd: Add compatible string for UART support

On Wed, Nov 30, 2022 at 01:12:55PM -0700, Mark Hasemeyer wrote:
> Add a compatible string to support the UART implementation of the cros
> ec interface.

$ git am ...
...
Applying: dt-bindings: mfd: Add compatible string for UART support
error: patch failed: Documentation/devicetree/bindings/mfd/google,cros-ec.yaml:28
error: Documentation/devicetree/bindings/mfd/google,cros-ec.yaml: patch does not apply
Patch failed at 0002 dt-bindings: mfd: Add compatible string for UART support

Please use either for-next branch or linux-next as base. There are DT binding
changes in the queue for 6.2.
- 7a2f36828c7b ("dt-bindings: cros-ec: Reorganize and enforce property
availability")
- e068bc0b01cf ("dt-bindings: cros-ec: Add ChromeOS fingerprint binding")

2022-12-01 20:02:02

by Rob Herring (Arm)

Subject: Re: [PATCH v8 2/3] dt-bindings: mfd: Add compatible string for UART support

On Wed, Nov 30, 2022 at 01:12:55PM -0700, Mark Hasemeyer wrote:
> Add a compatible string to support the UART implementation of the cros
> ec interface.
>
> Signed-off-by: Bhanu Prakash Maiya <[email protected]>
> Signed-off-by: Mark Hasemeyer <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>
> ---
>
> Changes in v8:
> - Update commit message
>
> Changes in v7:
> - No change
>
> Changes in v6:
> - No change
>
> Changes in v5:
> - No change
>
> Changes in v4:
> - Changes in commit message.
>
> Changes in v3:
> - Rebased changes on google,cros-ec.yaml
>
> Changes in v2:
> - No change
>
> ---
> .../devicetree/bindings/mfd/google,cros-ec.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> index 04962bb29576e..26787e4574b8d 100644
> --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> @@ -28,6 +28,9 @@ properties:
> - description:
> For implementations of the EC is connected through RPMSG.
> const: google,cros-ec-rpmsg
> + - description:
> + For implementations of the EC is connected through UART.
> + const: google,cros-ec-uart
>
> controller-data:
> description:
> @@ -222,4 +225,12 @@ examples:
> compatible = "google,cros-ec-rpmsg";
> };
> };
> +
> + # Example for UART
> + - |
> + uart0 {

serial {

> + cros-ec {
> + compatible = "google,cros-ec-uart";
> + };
> + };
> ...
> --
> 2.38.1.584.g0f3c55d4c2-goog
>
>