2022-12-08 11:02:58

by Matt Jan

Subject: [PATCH v2 1/3] staging: vme_user: add the spaces around the "*"

Add a space around the "*" at vme_bridge.h to clear up a checkpatch
check.

Signed-off-by: Matt Jan <[email protected]>
---
drivers/staging/vme_user/vme_bridge.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vme_user/vme_bridge.h b/drivers/staging/vme_user/vme_bridge.h
index 0bbefe9851d7..e17a8f7de165 100644
--- a/drivers/staging/vme_user/vme_bridge.h
+++ b/drivers/staging/vme_user/vme_bridge.h
@@ -4,7 +4,7 @@

#include "vme.h"

-#define VME_CRCSR_BUF_SIZE (508*1024)
+#define VME_CRCSR_BUF_SIZE (508 * 1024)
/*
* Resource structures
*/
--
2.25.1
v2: Resend the correct patch set, noted by Greg Kroah-Hartmamn <[email protected]>

2022-12-08 13:43:05

by Greg Kroah-Hartman

Subject: Re: [PATCH v2 1/3] staging: vme_user: add the spaces around the "*"

On Thu, Dec 08, 2022 at 06:38:13PM +0800, Matt Jan wrote:
> Add a space around the "*" at vme_bridge.h to clear up a checkpatch
> check.
>
> Signed-off-by: Matt Jan <[email protected]>
> ---
> drivers/staging/vme_user/vme_bridge.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vme_user/vme_bridge.h b/drivers/staging/vme_user/vme_bridge.h
> index 0bbefe9851d7..e17a8f7de165 100644
> --- a/drivers/staging/vme_user/vme_bridge.h
> +++ b/drivers/staging/vme_user/vme_bridge.h
> @@ -4,7 +4,7 @@
>
> #include "vme.h"
>
> -#define VME_CRCSR_BUF_SIZE (508*1024)
> +#define VME_CRCSR_BUF_SIZE (508 * 1024)
> /*
> * Resource structures
> */
> --
> 2.25.1
> v2: Resend the correct patch set, noted by Greg Kroah-Hartmamn <[email protected]>

This "v2" stuff goes below the "---" line, not down here below the patch
itself.

Also this series is not properly threaded at all, please use 'git
send-email' to do so so that our tools will properly pick up the whole
thread, and not just individual emails.

Can you fix this all up and send a v3 please?

thanks,

greg k-h