The triggers enum misses 3 cases used by gemini DT.
usb-host was added via commit 0cfbd328d60f ("usb: Add LED triggers for USB activity")
so we add also as valid trigger usb-gadget which was added along in this
commit.
disk-read/disk-write were added by commit d1ed7c558612 ("leds: Extends disk trigger for reads and writes")
Reviewed-by: Linus Walleij <[email protected]>
Acked-by: Rob Herring <[email protected]>
Signed-off-by: Corentin Labbe <[email protected]>
---
V1 can be seen at https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/
Changes since v1:
- rebased on recent tree
Changes since v2:
- rebased on recent tree
Documentation/devicetree/bindings/leds/common.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index f5c57a580078..8ebe602419b5 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -90,6 +90,8 @@ properties:
- heartbeat
# LED indicates disk activity
- disk-activity
+ - disk-read
+ - disk-write
# LED indicates IDE disk activity (deprecated), in new implementations
# use "disk-activity"
- ide-disk
@@ -98,6 +100,8 @@ properties:
# LED alters the brightness for the specified duration with one software
# timer (requires "led-pattern" property)
- pattern
+ - usb-gadget
+ - usb-host
# LED is triggered by SD/MMC activity
- pattern: "^mmc[0-9]+$"
- pattern: "^cpu[0-9]*$"
--
2.37.4
Le Fri, Oct 28, 2022 at 06:41:40AM +0000, Corentin Labbe a ?crit :
> The triggers enum misses 3 cases used by gemini DT.
> usb-host was added via commit 0cfbd328d60f ("usb: Add LED triggers for USB activity")
> so we add also as valid trigger usb-gadget which was added along in this
> commit.
>
> disk-read/disk-write were added by commit d1ed7c558612 ("leds: Extends disk trigger for reads and writes")
> Reviewed-by: Linus Walleij <[email protected]>
> Acked-by: Rob Herring <[email protected]>
>
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
Hello
Gentle ping
Regards
On Mon, Dec 12, 2022 at 1:59 PM Corentin LABBE <[email protected]> wrote:
> Le Fri, Oct 28, 2022 at 06:41:40AM +0000, Corentin Labbe a écrit :
> > The triggers enum misses 3 cases used by gemini DT.
> > usb-host was added via commit 0cfbd328d60f ("usb: Add LED triggers for USB activity")
> > so we add also as valid trigger usb-gadget which was added along in this
> > commit.
> >
> > disk-read/disk-write were added by commit d1ed7c558612 ("leds: Extends disk trigger for reads and writes")
> > Reviewed-by: Linus Walleij <[email protected]>
> > Acked-by: Rob Herring <[email protected]>
> >
>
> Hello Pavel Machek and Lee Jones
>
> The two patch are reviewed, could you take them to your tree ?
If the subsystem maintainers are too busy to respond, maybe you can propose
it for merging through the SoC tree? It's a common last way out.
Yours,
Linus Walleij
Le Fri, Oct 28, 2022 at 06:41:40AM +0000, Corentin Labbe a ?crit :
> The triggers enum misses 3 cases used by gemini DT.
> usb-host was added via commit 0cfbd328d60f ("usb: Add LED triggers for USB activity")
> so we add also as valid trigger usb-gadget which was added along in this
> commit.
>
> disk-read/disk-write were added by commit d1ed7c558612 ("leds: Extends disk trigger for reads and writes")
> Reviewed-by: Linus Walleij <[email protected]>
> Acked-by: Rob Herring <[email protected]>
>
Hello Pavel Machek and Lee Jones
The two patch are reviewed, could you take them to your tree ?
thanks
Regards
On Mon, 12 Dec 2022, Corentin LABBE wrote:
> Le Fri, Oct 28, 2022 at 06:41:40AM +0000, Corentin Labbe a écrit :
> > The triggers enum misses 3 cases used by gemini DT.
> > usb-host was added via commit 0cfbd328d60f ("usb: Add LED triggers for USB activity")
> > so we add also as valid trigger usb-gadget which was added along in this
> > commit.
> >
> > disk-read/disk-write were added by commit d1ed7c558612 ("leds: Extends disk trigger for reads and writes")
> > Reviewed-by: Linus Walleij <[email protected]>
> > Acked-by: Rob Herring <[email protected]>
> >
>
> Hello Pavel Machek and Lee Jones
>
> The two patch are reviewed, could you take them to your tree ?
I do not have access to these patches. Please [RESEND] them.
--
Lee Jones [李琼斯]