2022-11-24 00:08:31

by Jingyuan Liang

[permalink] [raw]
Subject: [PATCH] HID: Add Mapping for System Microphone Mute

HUTRR110 added a new usage code for a key that is supposed to
mute/unmute microphone system-wide.

This patch maps the new usage code(0x01 0xa9) to keycode KEY_MICMUTE.
Additionally hid-debug is adjusted to recognize this keycode as well.

Signed-off-by: Jingyuan Liang <[email protected]>
---

drivers/hid/hid-debug.c | 1 +
drivers/hid/hid-input.c | 8 ++++++++
2 files changed, 9 insertions(+)

diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
index 2ca6ab600bc9..15e35702773c 100644
--- a/drivers/hid/hid-debug.c
+++ b/drivers/hid/hid-debug.c
@@ -972,6 +972,7 @@ static const char *keys[KEY_MAX + 1] = {
[KEY_KBD_LAYOUT_NEXT] = "KbdLayoutNext",
[KEY_EMOJI_PICKER] = "EmojiPicker",
[KEY_DICTATE] = "Dictate",
+ [KEY_MICMUTE] = "MicrophoneMute",
[KEY_BRIGHTNESS_MIN] = "BrightnessMin",
[KEY_BRIGHTNESS_MAX] = "BrightnessMax",
[KEY_BRIGHTNESS_AUTO] = "BrightnessAuto",
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 859aeb07542e..6396ed434b37 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -781,6 +781,14 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
break;
}

+ if ((usage->hid & 0xf0) == 0xa0) { /* SystemControl */
+ switch (usage->hid & 0xf) {
+ case 0x9: map_key_clear(KEY_MICMUTE); break;
+ default: goto ignore;
+ }
+ break;
+ }
+
if ((usage->hid & 0xf0) == 0xb0) { /* SC - Display */
switch (usage->hid & 0xf) {
case 0x05: map_key_clear(KEY_SWITCHVIDEOMODE); break;
--
2.38.1.584.g0f3c55d4c2-goog


2022-12-13 00:24:52

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [PATCH] HID: Add Mapping for System Microphone Mute

On Wed, Nov 23, 2022 at 11:46:19PM +0000, Jingyuan Liang wrote:
> HUTRR110 added a new usage code for a key that is supposed to
> mute/unmute microphone system-wide.
>
> This patch maps the new usage code(0x01 0xa9) to keycode KEY_MICMUTE.
> Additionally hid-debug is adjusted to recognize this keycode as well.
>
> Signed-off-by: Jingyuan Liang <[email protected]>

Reviewed-by: Dmitry Torokhov <[email protected]>

Thanks.

--
Dmitry

2022-12-13 05:02:12

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH] HID: Add Mapping for System Microphone Mute

On Wed, Nov 23, 2022 at 11:46:19PM +0000, Jingyuan Liang wrote:
> This patch maps the new usage code(0x01 0xa9) to keycode KEY_MICMUTE.
> Additionally hid-debug is adjusted to recognize this keycode as well.

s/This patch maps/Map/

See Documentation/process/submitting-patches.rst for why.

--
An old man doll... just what I always wanted! - Clara

Attachments:
(No filename) (360.00 B)
 signature.asc (235.00 B)
 Download all attachments

2022-12-14 01:50:05

by Jingyuan Liang

[permalink] [raw]
Subject: Re: [PATCH] HID: Add Mapping for System Microphone Mute

Thank you for the comment. I made the change as suggested and uploaded another patch v2.