2022-12-19 13:26:18

by Andy Shevchenko

[permalink] [raw]
Subject: [PATCH v1 1/1] pinctrl: intel: Convert to generic_handle_domain_irq()

Replace construct that matches generic_handle_irq(irq_find_mapping())
to a single call to generic_handle_domain_irq().

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/pinctrl/intel/pinctrl-intel.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index 4029891ba628..8181a65fb815 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -1215,13 +1215,8 @@ static int intel_gpio_community_irq_handler(struct intel_pinctrl *pctrl,
/* Only interrupts that are enabled */
pending &= enabled;

- for_each_set_bit(gpp_offset, &pending, padgrp->size) {
- unsigned int irq;
-
- irq = irq_find_mapping(gc->irq.domain,
- padgrp->gpio_base + gpp_offset);
- generic_handle_irq(irq);
- }
+ for_each_set_bit(gpp_offset, &pending, padgrp->size)
+ generic_handle_domain_irq(gc->irq.domain, padgrp->gpio_base + gpp_offset);

ret += pending ? 1 : 0;
}
--
2.35.1


2022-12-19 15:02:34

by Mika Westerberg

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] pinctrl: intel: Convert to generic_handle_domain_irq()

On Mon, Dec 19, 2022 at 02:27:22PM +0200, Andy Shevchenko wrote:
> Replace construct that matches generic_handle_irq(irq_find_mapping())
> to a single call to generic_handle_domain_irq().
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Acked-by: Mika Westerberg <[email protected]>

2022-12-27 19:51:02

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] pinctrl: intel: Convert to generic_handle_domain_irq()

On Mon, Dec 19, 2022 at 04:33:41PM +0200, Mika Westerberg wrote:
> On Mon, Dec 19, 2022 at 02:27:22PM +0200, Andy Shevchenko wrote:
> > Replace construct that matches generic_handle_irq(irq_find_mapping())
> > to a single call to generic_handle_domain_irq().
> >
> > Signed-off-by: Andy Shevchenko <[email protected]>
>
> Acked-by: Mika Westerberg <[email protected]>

Pushed to my review and testing queue, thanks|

--
With Best Regards,
Andy Shevchenko