2022-12-17 23:07:22

by Changbin Du

Subject: [PATCH] perf: makefile: add .DELETE_ON_ERROR special target

As kbuild, this adds .DELETE_ON_ERROR special target to clean up
partially updated files on error. A known issue is the empty vmlinux.h
generted by bpftool if it failed to dump btf info.

Signed-off-by: Changbin Du <[email protected]>
Cc: Andrii Nakryiko <[email protected]>
---
tools/perf/Makefile.perf | 3 +++
1 file changed, 3 insertions(+)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 9b7886ce0674..13e7d26e77f0 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -1151,3 +1151,6 @@ FORCE:
.PHONY: archheaders

endif # force_fixdep
+
+# Delete partially updated (corrupted) files on error
+.DELETE_ON_ERROR:
--
2.37.2

2022-12-20 02:15:16

by Leo Yan

Subject: Re: [PATCH] perf: makefile: add .DELETE_ON_ERROR special target

On Sun, Dec 18, 2022 at 06:51:51AM +0800, Changbin Du wrote:
> As kbuild, this adds .DELETE_ON_ERROR special target to clean up
> partially updated files on error. A known issue is the empty vmlinux.h
> generted by bpftool if it failed to dump btf info.
>
> Signed-off-by: Changbin Du <[email protected]>
> Cc: Andrii Nakryiko <[email protected]>

Reviewed-by: Leo Yan <[email protected]>

2022-12-20 19:28:37

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf: makefile: add .DELETE_ON_ERROR special target

Em Tue, Dec 20, 2022 at 09:57:57AM +0800, Leo Yan escreveu:
> On Sun, Dec 18, 2022 at 06:51:51AM +0800, Changbin Du wrote:
> > As kbuild, this adds .DELETE_ON_ERROR special target to clean up
> > partially updated files on error. A known issue is the empty vmlinux.h
> > generted by bpftool if it failed to dump btf info.
> >
> > Signed-off-by: Changbin Du <[email protected]>
> > Cc: Andrii Nakryiko <[email protected]>
>
> Reviewed-by: Leo Yan <[email protected]>

Thanks, applied.

- Arnaldo