2023-01-10 15:59:19

by Vernon Yang

Subject: [PATCH] maple_tree: fix comment of mte_destroy_walk

The parameter name of maple tree is mt, so make the comment to correct.

Fixes: 54a611b60590 ("Maple Tree: add new data structure")
Signed-off-by: Vernon Yang <[email protected]>
---
lib/maple_tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 26e2045d3cda..69be9d3db0c8 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -5591,7 +5591,7 @@ static void mt_destroy_walk(struct maple_enode *enode, unsigned char ma_flags,
/*
* mte_destroy_walk() - Free a tree or sub-tree.
* @enode - the encoded maple node (maple_enode) to start
- * @mn - the tree to free - needed for node types.
+ * @mt - the tree to free - needed for node types.
*
* Must hold the write lock.
*/
--
2.34.1

2023-01-10 19:20:18

by Matthew Wilcox

Subject: Re: [PATCH] maple_tree: fix comment of mte_destroy_walk

On Tue, Jan 10, 2023 at 11:22:16PM +0800, Vernon Yang wrote:
> /*
> * mte_destroy_walk() - Free a tree or sub-tree.
> * @enode - the encoded maple node (maple_enode) to start
> - * @mn - the tree to free - needed for node types.
> + * @mt - the tree to free - needed for node types.

Should probably also fix the separator between the parameter name and
the description to be : instead of -.

2023-01-11 13:25:15

by Vernon Yang

Subject: Re: [PATCH] maple_tree: fix comment of mte_destroy_walk

On Tue, Jan 10, 2023 at 06:43:22PM +0000, Matthew Wilcox wrote:
> On Tue, Jan 10, 2023 at 11:22:16PM +0800, Vernon Yang wrote:
> > /*
> > * mte_destroy_walk() - Free a tree or sub-tree.
> > * @enode - the encoded maple node (maple_enode) to start
> > - * @mn - the tree to free - needed for node types.
> > + * @mt - the tree to free - needed for node types.
>
> Should probably also fix the separator between the parameter name and
> the description to be : instead of -.

Okay, thanks you for review.